Open
Conversation
dependabot
bot
added
dependencies
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.0.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-10.0.0
branch
from
28057bf to
cb76159
Compare
Code Review SummaryStatus: 2 Critical Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Details: ESLint 10 requires the flat config format. The current config files incorrectly use The configs should be structured like: export default [
eslint.configs.recommended,
...tseslint.configs.recommended,
{
files: ["emain/emain.ts", "electron.vite.config.ts"],
languageOptions: {
globals: {
...globals.node
}
}
},
eslintConfigPrettier
];Note: Files Reviewed (3 files)
Summary: This PR upgrades ESLint from 8.57.1 to 10.0.0, which is a major version with breaking changes. The upgrade requires:
Without these fixes, ESLint will fail to run after this upgrade is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint from 8.57.1 to 10.0.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4e6c4ac10.0.0ddd8a22Build: changelog update for 10.0.0bff9091feat: handleArray.fromAsyncinarray-callback-return(#20457)1ece282chore: ignore/docs/v9.xin link checker (#20452)034e139ci: add type integration test for@html-eslint/eslint-plugin(#20345)f3fbc2fchore: set@eslint/jsversion to 10.0.0 to skip releasing it (#20466)e978ddadocs: Update README4cecf83docs: Update READMEc79f0abdocs: Update READMEafc0681chore: remove scopeManager.addGlobals patch for typescript-eslint parser (#20...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)