Fix: [for cherry-picking] Updated the Go SDK generator to emit go 1.25. - #60
Fix: [for cherry-picking] Updated the Go SDK generator to emit go 1.25.#60qodo-code-review[bot] wants to merge 1 commit into
Conversation
|
PR author is in the excluded authors list. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| f.write( | ||
| f"module {MODULE}\n\n" | ||
| "go 1.24.0\n\n" | ||
| "go 1.25.0\n\n" |
There was a problem hiding this comment.
🟡 Minimum Go version raise is not recorded in the changelog
The raise of the minimum Go version demanded from everyone installing the Go SDK is applied in the generator (go 1.25.0 at codegen/render_go.py:87) without any matching entry added under the changelog's Unreleased section, so consumers get no notice of the new requirement.
Impact: Users upgrading the Go SDK can hit an unexplained toolchain requirement because the release notes never mention it.
Repository rule requiring changelog updates for user-facing changes
AGENTS.md states: "Conventional Commit titles; update CHANGELOG.md (Unreleased) for user-facing changes." The go directive in a published module is a consumer-visible minimum version, and CHANGELOG.md currently contains no entry for the 1.24.0 → 1.25.0 raise (neither for sdk-go/go.mod in the base commit nor for this generator sync).
Prompt for agents
AGENTS.md requires that user-facing changes are recorded in CHANGELOG.md under the Unreleased heading. This PR raises the generated sdk-go go directive from 1.24.0 to 1.25.0 (codegen/render_go.py, render()), which changes the minimum Go toolchain required by anyone consuming github.com/wave-av/sdks/sdk-go. Add an Unreleased entry describing the new Go floor (and the reason: 1.24 is EOL), keeping it consistent with the existing changelog format.
Was this helpful? React with 👍 or 👎 to provide feedback.
| f.write( | ||
| f"module {MODULE}\n\n" | ||
| "go 1.24.0\n\n" | ||
| "go 1.25.0\n\n" |
There was a problem hiding this comment.
🔍 CI setup-go pin (1.22) is now two majors below the module's go directive
With the generated go.mod demanding go 1.25.0, the workflows that pin go-version: "1.22" (.github/workflows/test-go.yml:34, .github/workflows/release-go.yml:25) only work because GOTOOLCHAIN=auto silently downloads a newer toolchain at build time (as documented in commit 3ee3cb3). This is not a build break, but it means every CI run pays a toolchain download and the pinned version is meaningless. Worth landing the referenced CI-pin fix (#26) alongside this change so the pin reflects reality; if a runner ever sets GOTOOLCHAIN=local, the Go jobs would fail outright.
Was this helpful? React with 👍 or 👎 to provide feedback.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Risk: low. Left a non-blocking comment because Cursor Security Agent was present but skipped, so it did not complete successfully; Cursor Bugbot was not present. Assigned a reviewer for human follow-up.
Sent by Cursor Approval Agent: Pull Request Router and Approver
ApprovabilityVerdict: Needs human review The author does not own the changed file (owned by wave-av/sdk-owners), and there is an unresolved comment noting the missing CHANGELOG entry for this user-facing Go version requirement change. The designated code owners should review this. You can customize Macroscope's approvability policy. Learn more. |
Fixed Findings
Automated fix from agentic review of #59
Note
Update Go SDK generator to emit
go 1.25.0in generatedgo.modUpdates the Go version directive in render_go.py from
go 1.24.0togo 1.25.0in the block that writesgo.modcontent.Macroscope summarized fff781a.