chore(guard): sync vendored public-repo-guard to canonical - #53
chore(guard): sync vendored public-repo-guard to canonical#53wave-av-release-bot[bot] wants to merge 1 commit into
Conversation
|
PR author is in the excluded authors list. |
ApprovabilityVerdict: Needs human review Unable to check for correctness in ecfae45. The changes are minor CI/CD security hardening (updating checkout action, disabling credential persistence), but the author (a bot) does not own this workflow file. The designated owners (wave-av/sdk-owners) should review changes to their CI configuration. You can customize Macroscope's approvability policy. Learn more. |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 |
There was a problem hiding this comment.
🔍 Checkout pin bumped only in this workflow; rest of repo still on v4 / floating tags
This is now the only workflow pinned to a v7 commit SHA; .github/workflows/_checks.yml pins v4.3.1 by SHA and ~10 other workflows (e.g. .github/workflows/publish-npm.yml:30, .github/workflows/test-go.yml:31) still use the mutable actions/checkout@v4 tag without persist-credentials: false. If the intent is supply-chain hardening (zizmor artipacked), the same treatment is missing across those workflows, several of which are publish jobs with elevated permissions.
Was this helpful? React with 👍 or 👎 to provide feedback.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 |
There was a problem hiding this comment.
🔍 Pinned commit SHA for v7.0.0 should be verified against upstream
The pin 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 cannot be validated from the repo contents. Since this workflow is the repository's security gate, confirm the SHA actually corresponds to the actions/checkout v7.0.0 tag upstream — a wrong SHA either fails the job outright or silently runs a different revision than the comment claims.
Was this helpful? React with 👍 or 👎 to provide feedback.
Syncs the vendored
public-repo-guardtrio to the canonical source inwave-foundation/scaffolder/public-repo-guard.internal-ipleak rule (Tailscale-CGNAT100.64.0.0/10), lockstep with the pre-publish mirror gateEach changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own
Secrets + content policygate re-scans this PR.🤖 Generated with Claude Code
Note
Update
public-repo-guardworkflow to useactions/checkoutv7 without persisted credentialsSyncs public-repo-guard.yml to the canonical version. Upgrades
actions/checkoutfrom v5.0.1 to v7.0.0 and setspersist-credentials: falseso theGITHUB_TOKENis no longer stored in the repository's Git config after checkout.Macroscope summarized ecfae45.
Summary by cubic
Syncs the vendored
public-repo-guardto the canonicalwave-foundation/scaffolder/public-repo-guard, adding an internal-IP leak rule for Tailscale CGNAT (100.64.0.0/10) and reconciling drift. Updates the guard workflow toactions/checkout@v7and setspersist-credentials: falseto avoid exposing the job token duringgitleaksscans.Written for commit ecfae45. Summary will update on new commits.