chore(gitignore): match node_modules as a symlink too - #52
Conversation
…directory
`node_modules/` with a trailing slash matches a DIRECTORY only. The documented
one-agent-one-worktree drill LINKS rather than copies
(`ln -s "$PWD/node_modules" /tmp/<lane>/node_modules`), and git treats a symlink as a FILE -- so the
pattern never matched it and every worktree carried a permanent `?? node_modules`.
Dropping the trailing slash matches both forms. Proven with `git check-ignore` against a symlink
probe before the sweep ran:
pattern 'node_modules/' -> symlink NOT ignored
pattern '/node_modules/' -> symlink NOT ignored
pattern 'node_modules' -> symlink IGNORED, and a real directory still IGNORED
So nothing that was ignored stops being ignored -- the change has no behavioural blast radius.
One of 98 identical fleet edits. Refs wave-av/wave-context#124.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
chore(gitignore): match node_modules as a symlink too, not only as a directory
node_modules/with a trailing slash matches a DIRECTORY only. The documentedone-agent-one-worktree drill LINKS rather than copies
(
ln -s "$PWD/node_modules" /tmp/<lane>/node_modules), and git treats a symlink as a FILE -- so thepattern never matched it and every worktree carried a permanent
?? node_modules.Dropping the trailing slash matches both forms. Proven with
git check-ignoreagainst a symlinkprobe before the sweep ran:
So nothing that was ignored stops being ignored -- the change has no behavioural blast radius.
One of 98 identical fleet edits. Refs wave-av/wave-context#124.
Verified after merge by re-fetching the committed bytes from the default branch.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Summary by cubic
Make
.gitignoreignorenode_moduleswhether it’s a directory or a symlink, so symlinked worktrees stop showing?? node_modules. This drops the trailing slash so Git matches both forms without affecting other ignores.Written for commit e39944f. Summary will update on new commits.