chore(facts): waive a disclosure false positive on the troubleshooting env-var reference - #83
chore(facts): waive a disclosure false positive on the troubleshooting env-var reference#83yakimoto wants to merge 2 commits into
Conversation
…g env-var reference The new disclosure gate (wave-av/wave-context#157) flags an env-var name near a state verb, because that pattern is how deployed configuration state leaks into published content. Here it is a false positive worth recording rather than silencing: the README's troubleshooting section tells the READER to check their OWN environment, so the variable belongs to the person installing the MCP server and says nothing about any WAVE deployment. Waivers are scoped to rule AND match together, so this excuses exactly this identifier and cannot quietly cover a genuine deployed value added later. The finding stays printed on every run - only the exit code ignores it. Unrelated and NOT addressed here: this repo already fails the policy gate on a pre-existing disallowed-url finding (an npm link outside the @wave-av scope), which predates this change.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7972715e-2a59-4988-a6f4-a4a35461e615) |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 38 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
PR Summary by QodoWaive disclosure gate false positive for README troubleshooting env var
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
ApprovabilityVerdict: Needs human review Unable to check for correctness in d8672f7. Unresolved review comments raise substantive concerns that the You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…isting npm link Two additions beyond the original disclosure waiver on this branch: 1. `description` declared in the SSOT. The live GitHub description claimed "19 tools"; the resolver-backed claim in this same file says 18, and the claim is the grounded number. The live description has been corrected to 18 and is now declared here, so the description drift gate compares against a checked value instead of unreviewed marketing copy. 2. `policyWaivers` entry for the @Anthropic-AI npm link. This repo already failed the policy gate on a pre-existing disallowed-url finding, unrelated to the new disclosure work. The link is legitimate - it is the published package a reader installs to use this server - so it is waived with a reason rather than removed. Scoped to that one npm org via pathPrefix, not the whole host, so an arbitrary third-party package link is still reported. Follow-up 5 of claude-workstation#1632.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ced9f66c-c50f-42f1-b612-55c456671cd0) |
The new disclosure gate (wave-av/wave-context#157) flags an environment-variable name appearing near a state verb, because that pattern is how deployed configuration state leaks into published content.
Here it is a false positive, and worth recording rather than silencing: the README's troubleshooting section tells the reader to check their own environment. The variable belongs to the person installing the MCP server; it says nothing about any WAVE deployment.
Waivers are scoped to
ruleandmatchtogether, so this excuses exactly this identifier and cannot quietly cover a genuine deployed value added later. The finding stays printed on every run — only the exit code ignores it, so the exception cannot outlive its justification unnoticed.Unrelated, and not addressed here
This repo already fails the policy gate on a pre-existing
disallowed-urlfinding — an npm link outside the@wave-avscope — which predates this change and this PR does not touch. Flagging it so it is not mistaken for fallout from the new gate.Note
Low Risk
Config-only changes to waiver metadata and description; no application or security logic is modified.
Overview
Updates
.wave/repo.jsonso WAVE facts/disclosure gates can pass with documented exceptions.Adds a
descriptionstring for the MCP server package metadata. IntroducespolicyWaiversforwww.npmjs.com/package/@anthropic-aiso README links to the Claude Agent SDK install package are allowed without tripping disallowed-url rules. AddsdisclosureWaiversfor ruleconfig-statewith matchWAVE_API_KEY, documenting that troubleshooting’secho $WAVE_API_KEYrefers to the installer’s env, not deployed WAVE config.Reviewed by Cursor Bugbot for commit d8672f7. Configure here.
Note
Waive
WAVE_API_KEYdisclosure false positive in WAVE repo scan configAdds a
disclosureWaiversentry in repo.json to suppress a false positive triggered by theWAVE_API_KEYenvironment variable reference used in troubleshooting docs. Also adds apolicyWaiversentry for the@anthropic-ainpm package path and a project description string.Macroscope summarized d8672f7.