chore(guard): sync vendored public-repo-guard to canonical - #80
chore(guard): sync vendored public-repo-guard to canonical#80wave-av-release-bot[bot] wants to merge 1 commit into
Conversation
|
PR author is in the excluded authors list. |
ApprovabilityVerdict: Needs human review Unable to check for correctness in 0699010. This PR makes a minor CI security improvement (bumping actions/checkout and adding persist-credentials: false), but the author does not own the modified workflow file which is designated to wave-av/core-team. The code owners should review changes to their workflow. You can customize Macroscope's approvability policy. Learn more. |
| # downloads a third-party binary (gitleaks, below) and runs it over the whole | ||
| # tree. Nothing here pushes -- the scan is `--no-git` over the working tree -- | ||
| # so no step needs authenticated Git; drop it. (zizmor: artipacked) | ||
| persist-credentials: false |
There was a problem hiding this comment.
🔍 persist-credentials: false is safe for this job's steps
Verified that no step in this job performs an authenticated git operation: gitleaks runs with --no-git --source . over the working tree (line 65), and content-policy.sh is invoked on the checkout directory only. Disabling credential persistence therefore does not break the scan. Worth confirming scripts/public-repo-guard/content-policy.sh never shells out to git fetch/git log against the remote, which would now fail for private-repo contexts.
Was this helpful? React with 👍 or 👎 to provide feedback.
Syncs the vendored
public-repo-guardtrio to the canonical source inwave-foundation/scaffolder/public-repo-guard.internal-ipleak rule (Tailscale-CGNAT100.64.0.0/10), lockstep with the pre-publish mirror gateEach changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own
Secrets + content policygate re-scans this PR.🤖 Generated with Claude Code
Note
Update
public-repo-guardworkflow to useactions/checkoutv7 without persisted credentialsSyncs public-repo-guard.yml to the canonical version. Upgrades
actions/checkoutfrom v5.0.1 to v7.0.0 and setspersist-credentials: falseso theGITHUB_TOKENis no longer stored in the repository's Git config after checkout.Macroscope summarized 0699010.
Summary by cubic
Synced the vendored
public-repo-guardtowave-foundation/scaffolder/public-repo-guardand added an internal IP leak rule for100.64.0.0/10(Tailscale CGNAT). Hardened the guard workflow by upgrading toactions/checkout@v7and disabling persisted credentials for scans.persist-credentials: falseforactions/checkoutsince scans run--no-gitand need no Git auth.Written for commit 0699010. Summary will update on new commits.