Skip to content

chore(gitignore): match node_modules as a symlink too - #70

Open
yakimoto wants to merge 1 commit into
mainfrom
chore/124-gitignore-node-modules-symlink
Open

chore(gitignore): match node_modules as a symlink too#70
yakimoto wants to merge 1 commit into
mainfrom
chore/124-gitignore-node-modules-symlink

Conversation

@yakimoto

@yakimoto yakimoto commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

chore(gitignore): match node_modules as a symlink too, not only as a directory

node_modules/ with a trailing slash matches a DIRECTORY only. The documented
one-agent-one-worktree drill LINKS rather than copies
(ln -s "$PWD/node_modules" /tmp/<lane>/node_modules), and git treats a symlink as a FILE -- so the
pattern never matched it and every worktree carried a permanent ?? node_modules.

Dropping the trailing slash matches both forms. Proven with git check-ignore against a symlink
probe before the sweep ran:

pattern 'node_modules/'   -> symlink NOT ignored
pattern '/node_modules/'  -> symlink NOT ignored
pattern 'node_modules'    -> symlink IGNORED, and a real directory still IGNORED

So nothing that was ignored stops being ignored -- the change has no behavioural blast radius.

One of 98 identical fleet edits. Refs wave-av/wave-context#124.

Verified after merge by re-fetching the committed bytes from the default branch.


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.


Summary by cubic

Ignore node_modules whether it’s a directory or a symlink by removing the trailing slash in .gitignore. Fixes untracked node_modules in worktrees that link the folder; no other ignore behavior changes. Refs wave-av/wave-context#124.

Written for commit 7c28f3c. Summary will update on new commits.

Review in cubic

…directory

`node_modules/` with a trailing slash matches a DIRECTORY only. The documented
one-agent-one-worktree drill LINKS rather than copies
(`ln -s "$PWD/node_modules" /tmp/<lane>/node_modules`), and git treats a symlink as a FILE -- so the
pattern never matched it and every worktree carried a permanent `?? node_modules`.

Dropping the trailing slash matches both forms. Proven with `git check-ignore` against a symlink
probe before the sweep ran:

    pattern 'node_modules/'   -> symlink NOT ignored
    pattern '/node_modules/'  -> symlink NOT ignored
    pattern 'node_modules'    -> symlink IGNORED, and a real directory still IGNORED

So nothing that was ignored stops being ignored -- the change has no behavioural blast radius.

One of 98 identical fleet edits. Refs wave-av/wave-context#124.
@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c28f3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a73c8e6f-0edd-4a42-9a8f-e042bf71f738

📥 Commits

Reviewing files that changed from the base of the PR and between a199245 and 7c28f3c.

📒 Files selected for processing (1)
  • .gitignore

Comment @coderabbitai help to get the list of available commands.

@yakimoto
yakimoto enabled auto-merge July 31, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant