Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ” Checkout pin bump is consistent within this workflow but diverges from the other workflow

All three jobs in .github/workflows/_checks.yml were updated consistently to the same commit SHA, so no partial migration inside this file. Note that .github/workflows/public-repo-guard.yml:45 still pins actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1, i.e. the repo now uses two different major versions of the action. Worth confirming whether the intent was to standardize on v5 rather than bumping the v4 line.

Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

with:
persist-credentials: false
- name: Secret scan (fail-closed, allowlist-aware)
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0
with:
persist-credentials: false
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ” SHA/tag comment pairing cannot be verified offline

The pinned SHA 11d5960a326750d5838078e36cf38b85af677262 is annotated as v4.4.0. Since pinned-by-SHA actions rely on the comment being accurate for future audits, it is worth confirming the SHA actually corresponds to the tag in the upstream actions/checkout repo (e.g. via git ls-remote --tags), as this cannot be validated from within this repository.

Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

with:
persist-credentials: false
- name: URL convention gate
Expand Down
Loading