Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Reusable workflow is a vendored copy of wave-foundation — check for drift

The header comment (lines 3-6) declares this file the "one source of truth" living in wave-av/wave-foundation, yet this repo carries its own copy. Bumping the pin here only fixes this repo; the upstream copy and any other consumers still reference the v4.3.1 SHA. Worth confirming the same Renovate bump lands upstream so the copies don't diverge.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
persist-credentials: false
- name: Secret scan (fail-closed, allowlist-aware)
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- name: URL convention gate
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/public-repo-guard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
name: Secrets + content policy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout SHA pin updated consistently, but comment/SHA pairing can't be verified locally

All four actions/checkout pins across .github/workflows/_checks.yml:23,54,114 and .github/workflows/public-repo-guard.yml:45 were updated to the same commit SHA, so the mechanical transformation is complete and consistent. The only unverifiable claim is that 3d3c42e5aac5ba805825da76410c181273ba90b1 actually corresponds to the v7.0.1 tag of actions/checkout — the trailing comment is the sole documentation of that mapping, and a mismatch would silently pin a different (possibly unintended) revision. Worth confirming against the upstream tag before merge.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟨 Checkout step in the public-repo-guard workflow keeps the job's GitHub token persisted in the checkout

The upgraded checkout step at .github/workflows/public-repo-guard.yml:45 does not set persist-credentials: false, unlike every other checkout in the repo (.github/workflows/_checks.yml:23,54,114). The workflow subsequently downloads and executes a third-party binary (gitleaks) and runs a repo-provided shell script (scripts/public-repo-guard/content-policy.sh), both of which would then run with the job token written into .git/config and available for git push/API use.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


# gitleaks' GitHub Action requires a paid license for organizations; the CLI
# itself is MIT-licensed and free. Pin the version AND verify the release
Expand Down
Loading