Skip to content

chore(guard): sync vendored public-repo-guard to canonical #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wave-av-release-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(guard): sync vendored public-repo-guard to canonical #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/public-repo-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ jobs:
name: Secrets + content policy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃攳 Verify the commit SHA actually corresponds to checkout v7.0.0

The action is pinned by SHA with a # v7.0.0 comment. Correctness of the pin cannot be validated from within the repo; a mismatched SHA/tag comment would silently run a different revision than reviewers assume. Worth confirming 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 is the tagged v7.0.0 commit of actions/checkout before merge. Functionally, dropping persisted credentials is safe here since no step performs authenticated Git operations (scan runs gitleaks detect --no-git --source .).

Open in Devin Review

Was this helpful? React with 馃憤 or 馃憥 to provide feedback.

with:
# Checkout defaults to persisting the job token for later steps: since v6 it
# lives in a file under $RUNNER_TEMP referenced from .git/config, no longer in
# .git/config itself. It is still a live credential in the job, and this job
# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false
Comment on lines +45 to +53

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃攳 Checkout pin bumped only in this workflow; other workflows still on v4

This PR upgrades actions/checkout to v7 with persist-credentials: false only in public-repo-guard.yml. The other workflows (.github/workflows/_checks.yml:23,54,114 and .github/workflows/foundation-gate.yml:44) still pin v4.3.1 and keep the default persist-credentials: true, so the artipacked hardening is inconsistent across the repo. If the intent is a repo-wide hardening sync, those workflows likely need the same treatment.

Open in Devin Review

Was this helpful? React with 馃憤 or 馃憥 to provide feedback.


# gitleaks' GitHub Action requires a paid license for organizations; the CLI
# itself is MIT-licensed and free. Pin the version AND verify the release
Expand Down
Loading