chore(deps): bump typescript from 5.9.3 to 7.0.2 - #49
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
fae5ff9 to
dd5044e
Compare
|
PR author is in the excluded authors list. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "eslint": "^9.39.4", | ||
| "tsup": "^8.0.0", | ||
| "typescript": "^5.9.0", | ||
| "typescript": "^7.0.2", |
There was a problem hiding this comment.
🔴 Lint tooling is incompatible with the new TypeScript version, breaking installs and checks
The project's TypeScript version is raised to 7.x ("typescript": "^7.0.2" at package.json:59) while the linting toolchain still declares support only up to 6.x, so installing dependencies and running the lint/type gates can fail.
Impact: Contributors and CI can hit dependency-resolution errors or a broken lint step until the linting toolchain is upgraded too.
Peer dependency range mismatch between typescript-eslint 8.60.1 and typescript 7.0.2
package-lock.json records typescript-eslint@8.60.1 (and its @typescript-eslint/* sub-packages, e.g. parser, typescript-estree) with peerDependencies: { "typescript": ">=4.8.4 <6.1.0" }, while node_modules/typescript is now resolved to 7.0.2. npm install without --legacy-peer-deps reports ERESOLVE, and even when installed, the type-aware ESLint config (eslint.config.js) runs against an unsupported compiler version. npm run lint (package.json:21) uses --max-warnings 0, so any tooling-level failure blocks the required gate.
Additionally, tsup@8.5.1 declares typescript: ">=4.5.0", but the --dts flow (package.json:19) relies on the TypeScript JS compiler API; TS 7 ships as native binaries, so declaration emit should be verified before merging.
Prompt for agents
The devDependency typescript was bumped from ^5.9.0 to ^7.0.2 in package.json, but typescript-eslint@8.60.1 (and all @typescript-eslint/* packages in package-lock.json) declare a peer dependency of typescript >=4.8.4 <6.1.0. This causes npm ERESOLVE failures on a clean install and leaves the type-aware lint config running against an unsupported compiler. Either hold the bump until typescript-eslint publishes a version supporting TypeScript 7, or upgrade typescript-eslint in the same PR and verify `npm ci`, `npm run lint`, `npm run type-check`, and `npm run build` (which uses tsup --dts, relying on the TypeScript JS API that TS 7 native builds may not provide) all succeed.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "eslint": "^9.39.4", | ||
| "tsup": "^8.0.0", | ||
| "typescript": "^5.9.0", | ||
| "typescript": "^7.0.2", |
There was a problem hiding this comment.
🔍 Major compiler bump may interact with tsconfig options and declaration emit
This is a major-version compiler bump (5.x -> 7.x) via a dependency bot. Beyond the peer-range conflict already reported, the repo's tsconfig.json uses moduleResolution: "Bundler", esModuleInterop, and declaration: true with noEmit: true, and the build relies on tsup --dts (package.json:19) for the .d.ts files that types/exports advertise. A TypeScript 7 native compiler can differ in supported options and does not expose the same JS compiler API surface, so reviewers should confirm npm run type-check and npm run build produce identical dist/index.d.ts / dist/cli/index.js output before merging.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 7.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](https://github.com/microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dd5044e to
45ca248
Compare
| "eslint": "^9.39.4", | ||
| "tsup": "^8.0.0", | ||
| "typescript": "^5.9.0", | ||
| "typescript": "^7.0.2", |
There was a problem hiding this comment.
🔍 CHANGELOG Unreleased not updated for a major toolchain bump
AGENTS.md requires updating CHANGELOG.md (Unreleased) for user-facing changes. This is a devDependency-only bump so it is arguably not user-facing, but a TypeScript major version changes the emitted dist/*.d.ts that consumers actually consume (the build runs tsup --dts). Worth a maintainer decision on whether an Unreleased entry is required here.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "eslint": "^9.39.4", | ||
| "tsup": "^8.0.0", | ||
| "typescript": "^5.9.0", | ||
| "typescript": "^7.0.2", |
There was a problem hiding this comment.
🔍 Lockfile grew a duplicated typescript-eslint subtree
The lockfile diff adds a full nested copy of the typescript-eslint dependency tree under node_modules/typescript-eslint/node_modules/... (package-lock.json:2948-3130), while top-level @typescript-eslint/scope-manager|types|visitor-keys remain at 8.60.1. Duplicated trees like this typically indicate the resolver could not satisfy constraints flatly; it is worth confirming the lockfile was regenerated without --force/--legacy-peer-deps before merging, since npm ci in .github/workflows/lint.yml installs strictly from it.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps typescript from 5.9.3 to 7.0.2.
Release notes
Sourced from typescript's releases.
Commits
Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.