chore(deps): update actions/checkout action to v7 - #34
Conversation
|
|
PR author is in the excluded authors list. |
🌊 WAVE BugBot — 12 finding(s)🔴 10 · 🟠 2
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
e04c834 to
532cff7
Compare
532cff7 to
cfa22aa
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🔍 Checkout pin remains without persist-credentials in the guard workflow
This is the only checkout invocation in the repo that omits with: persist-credentials: false, unlike the ones in .github/workflows/lint.yml:20-22 and .github/workflows/_checks.yml:23-25. The SHA bump was applied here, but the hardening convention used elsewhere was not, leaving the token persisted in .git/config while the gitleaks/content-policy scripts run. Pre-existing, but worth aligning while touching the line.
Was this helpful? React with 👍 or 👎 to provide feedback.
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🔍 Reusable workflow is a mirror copy — bump must also land upstream
The header comment (.github/workflows/_checks.yml:3-6, 47-50) states this file is a mirror of wave-foundation's shared checks.yml/validate-skills.py. Bumping the checkout pin only in this copy risks drift from the upstream source of truth; confirm the same SHA bump is applied there.
Was this helpful? React with 👍 or 👎 to provide feedback.
cfa22aa to
487f3ff
Compare
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🔍 Checkout pin bumped consistently across all workflows
All eight actions/checkout references in .github/workflows/ (_checks.yml:23,54,114, .github/workflows/lint.yml:20, .github/workflows/public-repo-guard.yml:45, .github/workflows/release.yml:44,81,166) now point at the same commit SHA, so the pin-bump transformation was applied completely — no stragglers on the previous v4/v5/v6 SHAs. Worth verifying out-of-band that the SHA 3d3c42e... actually corresponds to the v7.0.1 tag in actions/checkout, since the comment is the only thing asserting that mapping and a wrong comment would mislead future bumps.
Was this helpful? React with 👍 or 👎 to provide feedback.
41bf779 to
c965a72
Compare
c965a72 to
ea052ed
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🟨 Checkout in public-repo-guard leaves git credentials on the runner
The checkout step in .github/workflows/public-repo-guard.yml:45 is the only checkout in the repo without persist-credentials: false (all others, e.g. .github/workflows/lint.yml:21-22, set it). The job runs untrusted PR content (a vendored shell script and gitleaks over PR-provided files), so leaving the GITHUB_TOKEN persisted in .git/config widens the blast radius if any step is influenced by PR content.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Approved ea052ed Mechanical dependency update bumping actions/checkout from v4/v5/v6 to v7.0.1 across CI workflow files. No behavioral changes to workflows - only SHA pin updates. Review comments are informational suggestions about pre-existing issues, not bugs in this PR. You can customize Macroscope's approvability policy. Learn more. |
This PR contains the following updates:
v6.0.3→v7.0.1v5.0.1→v7.0.1v4.3.1→v7.0.1Release Notes
actions/checkout (actions/checkout)
v7.0.1Compare Source
v7.0.0Compare Source
v7Compare Source
v6.1.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.
Note
Update
actions/checkoutto v7.0.1 across all CI workflowsBumps the pinned
actions/checkoutaction from various older versions (v4–v6) to v7.0.1 (3d3c42e) in all GitHub Actions workflow files, including _checks.yml, lint.yml, public-repo-guard.yml, and release.yml.Macroscope summarized ea052ed.