Skip to content

chore(guard): sync vendored public-repo-guard to canonical #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wave-av-release-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(guard): sync vendored public-repo-guard to canonical #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/public-repo-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ jobs:
name: Secrets + content policy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout SHA/version comment pairing should be confirmed by pinact

The pin 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 cannot be verified offline. Prior commits in this repo (e.g. 0545008 "ci: exact version comment (v5.0.1) for pinact compatibility") show the SHA/comment pairing is machine-checked; worth confirming the SHA actually corresponds to the actions/checkout v7.0.0 tag before merge.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
# Checkout defaults to persisting the job token for later steps: since v6 it
# lives in a file under $RUNNER_TEMP referenced from .git/config, no longer in
# .git/config itself. It is still a live credential in the job, and this job
# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false
Comment on lines +45 to +53

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Security gate template handed to other repositories still uses the old, less-safe checkout settings

The shared copy of the guard workflow that other repos install from was left on the old checkout version without the credential-dropping setting (actions/checkout@93cb6efe… # v5.0.1 at workflow-templates/public-repo-guard.yml:45), while only the in-repo copy was updated, so every repo adopting the template keeps the old behaviour.
Impact: New and existing repositories that copy this security gate continue to run with the job credential persisted, and the two copies drift apart.

Template/self-instance sync convention and the drift introduced here

Historically both copies are updated together (e.g. commit fb12a86 touched .github/workflows/public-repo-guard.yml and workflow-templates/public-repo-guard.yml in the same change). This PR only bumps the self-instance to actions/checkout@9c091bb… # v7.0.0 plus persist-credentials: false (.github/workflows/public-repo-guard.yml:45-53); diff between the two files now shows exactly that hunk as the only difference. Since the template is the distributable artifact for spokes, the hardening never reaches them.

Prompt for agents 
The public-repo-guard workflow exists in two places that are conventionally kept byte-identical: .github/workflows/public-repo-guard.yml (the canonical self-instance) and workflow-templates/public-repo-guard.yml (the copy spokes install). This PR upgraded actions/checkout to v7.0.0 and added persist-credentials: false only in the self-instance, leaving the template pinned at v5.0.1 with credentials persisted. Apply the same checkout pin and persist-credentials: false (with the explanatory comment) to workflow-templates/public-repo-guard.yml so the two files stay in sync and downstream public repos get the hardening.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +45 to +53

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟨 Distributed guard template still persists job credentials during third-party binary execution

The PR removes the persisted job token in the repo's own guard workflow but leaves the spoke-facing template (workflow-templates/public-repo-guard.yml:45) on the old checkout pin without persist-credentials: false, so every repo installing the template keeps a live Git credential in the workspace while a downloaded third-party gitleaks binary is executed over the tree (the very risk the new comment in .github/workflows/public-repo-guard.yml:47-52 describes).

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


# gitleaks' GitHub Action requires a paid license for organizations; the CLI
# itself is MIT-licensed and free. Pin the version AND verify the release
Expand Down