fix(codegen): add operator==/operator<< for generated union types - #94
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(codegen): add operator==/operator<< for generated union types#94devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…structs containing unions compile - Emit member operator==/!= and a STRUCPP_TEST friend operator<< inside every C++ union. - Flatten inline anonymous struct members into leaf field comparisons/display fragments. - Add st-validation regression for a struct containing a union with ASSERT_EQ and member access. Closes #92 and the union-related gaps in #86/#90. Co-Authored-By: Simon Atti <wattimedia@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
|
Verified PR #94 end-to-end — all green.
Full report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
STRUCTthat contained aUNION-typed member failed to compile because the generated C++unionhad nooperator==oroperator<<, so the struct's own generated comparison and test-display helpers could not resolve.This change makes every generated
unionemit:operator==/operator!=that compare all leaf members (flattening inline anonymous structs used for nested struct overlays).friend std::ostream& operator<<under#ifdef STRUCPP_TESTsoASSERT_EQon structs/FBs containing unions can display the value.Pseudo-diff
Test coverage
tests/st-validation/data_types/union_in_struct.standtest_union_in_struct.st, which define aSTRUCTcontaining aUNIONand exercise both member access andASSERT_EQon the struct variable.Verification
npm run typecheckcleannpx eslint src/ --quietcleannpm test: 128 files / 2343 passedStruc-ToolTest1downstream: 17 files / 51 passedCloses #92 and the union-related items in #86 / #90.
Link to Devin session: https://app.devin.ai/sessions/01bd5a0c3ebc4e3a93e5228eb07cf11b
Requested by: @wattzor