fix(codegen): emit operator==/operator<< for unions so structs containing unions compile - #93
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…ning unions compile - generateUnionType now emits operator==, operator!=, and a test-only operator<< so generated C++ headers compile when a STRUCT contains a UNION. - Add unit-test assertions and an end-to-end st-validation fixture for a SOCKADDRESS-style struct that embeds an INADDR union. Co-Authored-By: Simon Atti <wattimedia@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
Test report: union-in-struct codegen fixI verified the PR end-to-end on the End-to-end CLI proofThe new node dist/node/cli.js tests/st-validation/data_types/union_in_struct.st \
--test tests/st-validation/data_types/test_union_in_struct.stnode dist/node/cli.js tests/st-validation/data_types/union_in_struct.st \
-o /tmp/sockaddr_build/ --buildGenerated operators
Static checks & coverage
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92.
generateUnionTypenow emitsoperator==andoperator!=using raw byte comparison overiec_byte_size, plus a test-onlyoperator<<fallback so generated C++ headers compile when aSTRUCTcontains aUNIONmember.SysSockettypes such asSOCKADDRESS, whosesin_addrfield is theINADDRunion.tests/backend/type-codegen.test.tsand a newtests/st-validation/data_types/union_in_struct.st+test_union_in_struct.stend-to-end fixture that exercises aSOCKADDRESS-style struct with an embedded union.Checklist
npm run typecheckandnpx eslint src/ --quietpass.npm testpasses.IEC_COMPLIANCE.md,CODESYS_CLAIMS_LEDGER.md,README.md, etc.) if the change affects any behavior or claim covered by those docs.Link to Devin session: https://app.devin.ai/sessions/8240483b7529498a8a4d3181be8fbe66
Requested by: @wattzor