docs: apply review feedback to review readability design doc#95
Merged
Conversation
Address 6 review findings (2 P1, 4 P2): - P1: Fix formatGutter truthiness check to use !== undefined - P1: Add pendingBracket visual feedback design in footer - P2: Document n/N vs ]c/[c wrap-around behavior difference - P2: Add timeout-less UX impact analysis for 2-key sequence - P2: Add commit view line number gutter to edge case table - P2: Add roadmap.md update to out-of-scope section https://claude.ai/code/session_015NbnHYsXMH45WpAakjZoki
Add before/after line numbers to add, delete, and context diff lines using a dimColor gutter format (e.g. " 3 4 │ "). Header and comment lines are unaffected. https://claude.ai/code/session_015NbnHYsXMH45WpAakjZoki
Add Vim-style ]c (next change) and [c (previous change) keybindings to jump between add/delete lines in the PR detail diff view. Uses a pendingBracket state for 2-key sequence handling with visual feedback in the footer. https://claude.ai/code/session_015NbnHYsXMH45WpAakjZoki
Update requirements.md, roadmap.md, README.md, and design doc to reflect the implemented line number gutter and ]c/[c change line jump features. https://claude.ai/code/session_015NbnHYsXMH45WpAakjZoki
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address 6 review findings (2 P1, 4 P2):
https://claude.ai/code/session_015NbnHYsXMH45WpAakjZoki