Skip to content

test(workflow): add symlink loop detection tests for LoadWorkflowFile#78

Merged
watany-dev merged 1 commit into
mainfrom
claude/add-symlink-loop-test-aN6PR
Dec 28, 2025
Merged

test(workflow): add symlink loop detection tests for LoadWorkflowFile#78
watany-dev merged 1 commit into
mainfrom
claude/add-symlink-loop-test-aN6PR

Conversation

@watany-dev

Copy link
Copy Markdown
Owner

Add comprehensive tests to verify that LoadWorkflowFile properly handles
circular symlinks during YAML file loading:

  • Self-referencing symlink (file.yml -> file.yml)
  • Circular symlink chain (a.yml -> b.yml -> a.yml)
  • Deep symlink chain (10-link circular chain)
  • Symlink through directories with loop
  • Relative symlink loop (./current.yml -> ./current.yml)
  • Triple symlink loop (x.yml -> y.yml -> z.yml -> x.yml)
  • Valid symlink to real file (positive test case)

These tests ensure the OS-level symlink loop detection ("too many levels
of symbolic links" error) is properly surfaced and that the function
does not hang when encountering circular references.

Add comprehensive tests to verify that LoadWorkflowFile properly handles
circular symlinks during YAML file loading:

- Self-referencing symlink (file.yml -> file.yml)
- Circular symlink chain (a.yml -> b.yml -> a.yml)
- Deep symlink chain (10-link circular chain)
- Symlink through directories with loop
- Relative symlink loop (./current.yml -> ./current.yml)
- Triple symlink loop (x.yml -> y.yml -> z.yml -> x.yml)
- Valid symlink to real file (positive test case)

These tests ensure the OS-level symlink loop detection ("too many levels
of symbolic links" error) is properly surfaced and that the function
does not hang when encountering circular references.
@watany-dev watany-dev merged commit 0d207b2 into main Dec 28, 2025
4 checks passed
@watany-dev watany-dev deleted the claude/add-symlink-loop-test-aN6PR branch December 28, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants