wifi fault to log - #378
Open
paulmullin wants to merge 3 commits into
Open
Conversation
Contributor
|
Developer build links: Sys11 (Tiny) WPC EM WhiteStar DataEast Classic |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves WiFi connection diagnostics and resilience in Vector’s MicroPython networking layer by ensuring CYW43/WLAN failures during initial connect are logged persistently, and by fixing an SSID status message formatting bug in the backend’s WiFi connect flow.
Changes:
- Wrap
phew.connect_to_wifi()operations in atry/exceptto log CYW43/WLAN exceptions instead of allowing an unlogged traceback. - Fix SSID console output to use an f-string so the actual SSID is printed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/common/phew/__init__.py |
Adds exception logging around WiFi connect flow to capture CYW43/WLAN faults during connect/status polling. |
src/common/backend.py |
Fixes SSID connect message to correctly interpolate the SSID value. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| status = wlan.status() | ||
|
|
||
| logging.debug(f" - {statuses.get(status, 'unknown status')}") # got '2' as status sometimes | ||
| while not wlan.isconnected() and (time.ticks_ms() - start) < (timeout_seconds * 1000): |
mullinmax
reviewed
Aug 26, 2026
| start = time.ticks_ms() | ||
| status = wlan.status() | ||
|
|
||
| logging.debug(f" - {statuses.get(status, 'unknown status')}") # got '2' as status sometimes |
Contributor
There was a problem hiding this comment.
Suggested change
| logging.debug(f" - {statuses.get(status, 'unknown status')}") # got '2' as status sometimes | |
| logging.debug(f" - {statuses.get(status, f'unknown status {status}')}") # got '2' as status sometimes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Log wifi faults on intial connect and retries (catch all CYW43 errors
Related Issues
Motivation and Context
Testing
Screenshots (if applicable)
Types of Changes
Checklist
Additional Notes