WPC Ball in play config corrections - #374
Merged
Merged
Conversation
Contributor
|
Developer build links: Sys11 (Tiny) WPC EM WhiteStar DataEast Classic |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WPC configuration for Addams Family to correct the memory location used to read “Ball In Play,” and bumps reported firmware versions so the update can be distributed/identified properly in the Vector ecosystem.
Changes:
- Bump WPC
SystemVersionto1.7.13. - Update Addams Family (L2/H2)
BallInPlay.Addressvalues in WPC JSON configs. - Bump common
VectorVersionto1.11.29.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wpc/systemConfig.py | Bumps WPC firmware version constant. |
| src/wpc/config/AddamsFam_L2.json | Updates Ball In Play address for Addams Family L2 config. |
| src/wpc/config/AddamsFam_H2.json | Updates Ball In Play address for Addams Family H2 config. |
| src/common/SharedState.py | Bumps shared Vector version constant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mullinmax
previously approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some WPC games with incorrect ball in play locations.
Turns out we need a ball in play data capture when the DMD does not show ball in play to discriminate between DMD buffer and the actual ball in play location (on some games)
Also fixed HSrewards fault message for games that do not have HSrewards defined
Related Issues
Motivation and Context
Testing
Screenshots (if applicable)
Types of Changes
Checklist
Additional Notes