fix: hydrate cloud mode input from viewed run config#11167
Merged
Conversation
Preserve the run snapshot environment and model when joining existing cloud sessions so the input pills do not fall back to unrelated defaults while web session state is loading. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR preserves viewed cloud-session configuration by hydrating the environment ID and Oz model override from the run's agent config snapshot, with regression coverage for both paths.
Concerns
⚠️ [IMPORTANT] This changes user-facing Cloud Mode selector/model hydration behavior, but the PR description does not include screenshots or a screen recording demonstrating the viewed-session environment and model pill state end to end. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_config_snapshot.model_id.Tests
cargo test --manifest-path /workspace/warp/app/Cargo.toml viewed_task_config --libcargo test --manifest-path /workspace/warp/app/Cargo.toml terminal::view::ambient_agent::model::tests --libConversation: https://staging.warp.dev/conversation/9137ae95-5fb4-4bbd-99d6-810fa7297eda
Run: https://oz.staging.warp.dev/runs/019e38ab-9e8e-7a5e-91bb-6cbb7191bec4
This PR was generated with Oz.