Handle remote install filesystem environment failures#11150
Draft
alokedesai wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
df -Pk/df -Pibefore direct remote install and before SCP fallback upload.RemoteServerInstallationevent:is_environment_failure,counts_as_product_error, andsetup_failure_class.Base branch note
The requested base branch
aloke/remote_code_errors_newwas not fetchable in this cloud checkout (fatal: couldn't find remote ref aloke/remote_code_errors_new). Per orchestrator fallback instructions, this PR targetsmaster.Diff summary
Validation
cargo fmt --manifest-path /workspace/warp/Cargo.toml --all✅cargo test --manifest-path /workspace/warp/Cargo.toml -p remote_server✅ (77 passed)cargo check --manifest-path /workspace/warp/Cargo.toml -p warp✅cargo clippy --manifest-path /workspace/warp/Cargo.toml -p remote_server --all-targets✅cargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp --lib✅Visual/artifact evidence
/tmp/warp_remote_fs_artifacts/permission_denied_preflight.log(artifact uid019e3756-e39a-7343-aa33-f0ac797fc24a) shows the production install script exits with code 4 and emitswarp_remote_server_filesystem_preflight_failed kind=permission_denied ... detail=mkdir_failedbefore download/extraction./tmp/warp_remote_fs_artifacts/telemetry_disambiguation_evidence.json(artifact uid019e3756-e595-7c8c-93d1-dc4f7887cf5d) shows the intended telemetry disambiguation values:is_environment_failure=true,counts_as_product_error=false, andsetup_failure_class=unsupported_environment./tmp/warp_remote_fs_artifacts/screenshot_permission_denied_preflight_log.png(artifact uid019e3759-1f0e-715e-8e05-73e1957f86c0) is the GUI screenshot of the preflight log./tmp/warp_remote_fs_artifacts/screenshot_telemetry_disambiguation_evidence_json.png(artifact uid019e3759-20ca-76f7-8765-5c3c03368384) is the GUI screenshot of the telemetry evidence JSON.Limitations
dockeris not installed in this sandbox, so I could not create an SSH-enabled constrained Linux container. The artifact uses the closest available Linux reproduction: running the production install script asnobodywith an unwritable$HOME, which exercises the same remote filesystem preflight marker/classification path.Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/6766a133-e188-46b5-9181-c3ee589d58f8
Run: https://oz.staging.warp.dev/runs/019e3748-dacf-7650-b1ff-abfb5fd05e58
This PR was generated with Oz.