Package Swift runtime dylibs with macOS CLI#11149
Draft
alokedesai wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/.../bundle/osx/libusingxcrun swift-stdlib-tool.LC_RPATH @executable_path/libto the standalone CLI before signing so@rpath/libswift*.dylibresolves from the adjacentlib/directory.lib/, andresources/.lib/in macOS CLI release tarballs when present and validate the tarball launch layout in the macOS release workflow.lib/directories to$install_dir/libvialib.tmpwithout changing the remote-server binary path.lib/libswiftCore.dylib.Diff summary
Base branch note
The requested cloud base
origin/aloke/remote_code_errors_newwas not available (fatal: couldn't find remote ref aloke/remote_code_errors_new/ GitHub branch lookup returned 404), so this PR targetsmasterper fallback instructions.Validation
cargo fmt --manifest-path /workspace/warp/Cargo.toml --all✅cargo test --manifest-path /workspace/warp/Cargo.toml -p remote_server install_script_✅install_script_avoids_pattern_substitution_for_tilde_expansioninstall_script_tilde_expansion_resolves_correctlyinstall_script_installs_packaged_lib_directorycargo clippy --manifest-path /workspace/warp/Cargo.toml -p remote_server --tests✅warpui_core/warpui; no error after changing the new test to usecommand::blocking::Command.bash -n script/macos/bundle✅bash -n crates/remote_server/src/install_remote_server.sh✅git --no-pager diff --check✅Artifact / computer-use proof
This cloud worker is Linux, so macOS-only commands (
otool,install_name_tool,xcrun swift-stdlib-tool,codesign,notarytool) and macOS x86_64 dyld launch cannot execute here. I attached the closest reproducible proof artifacts to the Oz run:validation.txt(019e3751-8e89-7944-be3c-80c927b2e02c): validation transcript, Linux limitation note, and synthetic top-level tar layout listing.oz-dev-macos-x86_64.synthetic.tar.gz(019e3751-a3f9-7e99-9c10-c54f34b2fb5c): synthetic tarball showing the intended top-leveloz-dev,resources/, andlib/libswiftCore.dyliblayout.The release workflow now performs the host-specific verification on macOS by listing the tarball, checking
otool -Lfor Swift deps, checkingLC_RPATH, assertinglib/libswift*.dylibis in the tarball when Swift deps are present, extracting the tarball, and runningoz-<channel> --versionfrom the extracted layout.macOS follow-up commands
Run on a macOS x86_64-capable host or the
release_macos_cliworkflow:Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/e30bebc5-db94-43cf-ae36-cf57f23fdc7a
Run: https://oz.staging.warp.dev/runs/019e3748-d963-7283-b3b4-144d9a132143
This PR was generated with Oz.