Clean up WorkflowAliases feature flag#11139
Conversation
|
@oz-for-oss[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the WorkflowAliases feature flag and makes workflow aliases always available across completion, workflow editing, input submission, and telemetry.
Concerns
SessionContext::newnow always reads theWorkflowAliasessingleton, which breaks callers that construct a minimalApp::testwithout registering that settings group.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| } else { | ||
| Default::default() | ||
| }; | ||
| let workflow_aliases = WorkflowAliases::as_ref(ctx).autocomplete_data(ctx); |
There was a problem hiding this comment.
SessionContext::new is used by minimal unit-test apps that do not register WorkflowAliases; removing the flag guard makes every construction look up that singleton and will panic unless those callers register the settings group first.
1 participant
Automated cleanup of the
WorkflowAliasesfeature flag.This PR was generated by the feature flag cleanup workflow.