Skip to content

Move GenericCloudObject to warp_server_client.#11115

Draft
vorporeal wants to merge 1 commit into
david/move-GenericServerObject-to-warp_server_clientfrom
david/move-GenericCloudObject-to-warp_server_client
Draft

Move GenericCloudObject to warp_server_client.#11115
vorporeal wants to merge 1 commit into
david/move-GenericServerObject-to-warp_server_clientfrom
david/move-GenericCloudObject-to-warp_server_client

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 16, 2026

Description

Moves GenericCloudObject into warp_server_client while keeping app-local cloud object behavior in warp.

The upstream type now owns the portable data/container behavior: model accessors, constructors, server update/conflict handling, and portable upsert params. The app crate continues to own CloudObject, CloudModelType, persistence events, queue behavior, UI/Drive integration, and other runtime-specific logic.

This also adds app-local lookup extension traits so type aliases can keep readable calls like CloudAmbientAgentEnvironment::get_all(ctx), CloudScheduledAmbientAgent::get_by_id(...), and CloudMCPServer::get_by_uuid(...) without duplicating helper functions or making the upstream crate depend on AppContext/CloudModel.

Testing

Validated on the stack tip after Phase 3:

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
  • git --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label May 16, 2026
Copy link
Copy Markdown
Contributor Author

vorporeal commented May 16, 2026

@vorporeal vorporeal force-pushed the david/move-GenericCloudObject-to-warp_server_client branch from a4c4a9f to cd81967 Compare May 18, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant