fix: AEAD stream finalization, secure wipe, and password confirmation#4
Open
vylarion wants to merge 1 commit into
Open
fix: AEAD stream finalization, secure wipe, and password confirmation#4vylarion wants to merge 1 commit into
vylarion wants to merge 1 commit into
Conversation
2. Secure Wipe 3. Password Confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncryptedWriter now calls encrypt_last() for the final chunk via an explicit finalize() method. DecryptedReader uses a lookahead pattern to detect the final encrypted chunk and decrypt it with decrypt_last().
Implement real secure wipe (security) The --wipe flag used fs::remove_file() which only unlinks the file — data remains on disk and is forensically recoverable. Now overwrites file contents with cryptographically random data and calls sync_all() before unlinking. Directories are recursively wiped file-by-file.
Add password confirmation on pack (UX) pack now prompts for password confirmation to prevent typos that would make data irrecoverable, which is especially critical when combined with --wipe.