Return to voku/portable-utf8

[dmnc]

Reverts #33 to move from joomla\string back to voku/portable-utf8. The latter is not abandoned as suggested in the previous PR, although there did seem to be some indication in the discussion there that joomla/string may be soon.

The main reason I would like to do this is to address #38.

I also removed some deprecations by deleting the CsvFileVerboseIterator that was only used for one language and adding #[ReturnTypeWillChange] attributes to maintain PHP 7 support.

[dmnc]

Thank you @HLeithner for your very speedy review. I have now removed the deprecated UTF8::str_replace calls.

[HLeithner]

Thank you @HLeithner for your very speedy review. I have now removed the deprecated UTF8::str_replace calls.

I think not all?

[dmnc]

Thank you @HLeithner for your very speedy review. I have now removed the deprecated UTF8::str_replace calls.

I think not all?

I can't find any more with a few different methods of code search. Are you able to link to where you are seeing an issue please? One of your comments may look like I missed it, as it was referring to the line after the call itself so may not have auto-resolved.

[HLeithner]

ok, it seem github ui tricked me...

[dmnc]

@HLeithner Thank you for approving. Do you have merge and release privileges or do we need to alert another maintainer?

[HLeithner]

Yes I can but I would like to have some other things fixed too and move forward in php support with type hints.
Would be nice if you can help on this topic.

I created a 5.0 branch and will merge this pr into 5.0-dev, so you can reference it even if it's not tagged yet

[dmnc]

Hi @HLeithner

Do you have any specific plans about what you'd like to do with 5.x? I can see you have some changes in https://github.com/wamania/php-stemmer/pull/40/changes. Is the goal mainly to eliminate deprecations or are there breaking features? If it's the former, I would suggest we try to get a Rector config in and use that to tidy up. It should be releasable under 4.x as a non-breaking change, if we're careful.

Until then, might it be possible to get this released on the 4.x train please? I believe it should be interface invisible and releasing it as a bugfix would mean the change can cascade into other packages that are currently being inadvertently affected by the joomla/string copy left requirement. RubixML is one example I'm aware of but looking down the list on Packagist there are quite a few others there that are on the MIT licence too.

[dmnc]

I would suggest we try to get a Rector config in and use that to tidy up.

Here is an example https://github.com/wamania/php-stemmer/pull/41/changes