-
Notifications
You must be signed in to change notification settings - Fork 46
Update Development Documentation #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 73.61% 73.61%
=======================================
Files 50 50
Lines 6929 6929
Branches 1315 1315
=======================================
Hits 5101 5101
Misses 1283 1283
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Development documentation by creating a static artifacts link for collected test values and adjusting workflow behavior according to feedback from @precicely.
- Capitalized the artifact upload step name.
- Removed the caching condition on the artifact upload.
- Updated workflow steps to output the artifact URL.
Files not reviewed (1)
- docs/development/development_environment.rst: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/pytest.yml:63
- The removal of the caching condition in the artifact upload step may lead to unnecessary uploads. If this change is intentional, consider documenting the rationale for removing the condition.
if: ${{ steps.matlab-refs-cache.outputs.cache-hit != 'true' }}
This PR creates a static artifacts link for collected test values and updates the Development documentation based on feedback from @precicely