Add tests for filtering on django-treebeard tree operations#91
Open
gasman wants to merge 2 commits intowagtail:mainfrom
Open
Add tests for filtering on django-treebeard tree operations#91gasman wants to merge 2 commits intowagtail:mainfrom
gasman wants to merge 2 commits intowagtail:mainfrom
Conversation
laymonage
reviewed
Apr 14, 2026
Comment on lines
+797
to
+821
| def test_get_ancestors_filter_mp_node(self): | ||
| dog = models.MPAnimal.objects.get(name="Dog") | ||
| results = self.backend.search("mammal", dog.get_ancestors()) | ||
| self.assertCountEqual( | ||
| [r.name for r in results], | ||
| ["Mammal"], | ||
| ) | ||
| results = self.backend.search("reptile", dog.get_ancestors()) | ||
| self.assertCountEqual( | ||
| [r.name for r in results], | ||
| [], | ||
| ) | ||
|
|
||
| def test_get_ancestors_filter_ns_node(self): | ||
| dog = models.NSAnimal.objects.get(name="Dog") | ||
| results = self.backend.search("mammal", dog.get_ancestors()) | ||
| self.assertCountEqual( | ||
| [r.name for r in results], | ||
| ["Mammal"], | ||
| ) | ||
| results = self.backend.search("reptile", dog.get_ancestors()) | ||
| self.assertCountEqual( | ||
| [r.name for r in results], | ||
| [], | ||
| ) |
Member
There was a problem hiding this comment.
Since they share the same APIs and fixtures, I think my preference would be to avoid duplicating the tests somehow. For example, extracting these into a separate test class with model = models.MPAnimal and use self.model to refer to it, and then create a subclass that only adds model = models.NSAnimal. It would help running a subset of the tests when you only care about the treebeard ones, as well as making sure we apply any new tests to both MP and NS trees.
Alternatively, use subTest() with cases = [models.MPAnimal, models.NSAnimal], but that needs to be done for each case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wanted to investigate what was needed to support searching querysets from django-treebeard operations such as
get_descendants, and was pleasantly surprised to discover that they already worked :-) So, add unit tests to formalise that.(The trickier part is to ensure that the path field stored in the Elasticsearch/OpenSearch index is kept in sync with the database, even after nodes have been updated with
queryset.update- have opened django-treebeard/django-treebeard#381 to tackle that...)AI usage
Github Copilot code completion for tests and fixtures.