Skip to content

Use queryish library for results objects#35

Closed
gasman wants to merge 1 commit intowagtail:mainfrom
gasman:cleanup/queryish
Closed

Use queryish library for results objects#35
gasman wants to merge 1 commit intowagtail:mainfrom
gasman:cleanup/queryish

Conversation

@gasman
Copy link
Copy Markdown
Contributor

@gasman gasman commented Oct 13, 2025

queryish is a library I created for wrapping arbitrary datasources with an API that's consistent with Django's queryset - originally so that we could have choosers in Wagtail that pick objects from a REST API instead of the local database. This of course is a good fit for django-modelsearch's BaseSearchResults class.

Refactoring BaseSearchResults on top of Queryish allows us to eliminate a chunk of code, benefit from Queryish's wider unit testing for features like slicing and result caching, and potentially support a larger subset of the Queryset API (.first() is a quick win that works now; with more work it could be possible to support chaining things like .filter and .get after the search clause).

@kaedroho
Copy link
Copy Markdown
Collaborator

Hi @gasman, sorry I haven't had a chance to test this, are you happy for it to slide to 1.2?

@kaedroho kaedroho closed this Jan 26, 2026
@kaedroho
Copy link
Copy Markdown
Collaborator

Interesting, I didn't close this. It seemed to close by itself when I merged #39 and I can't reopen.

Please could you resubmit?

@gasman
Copy link
Copy Markdown
Contributor Author

gasman commented Jan 26, 2026

@kaedroho Sure - opened #63 now. I suspect Github might have some mixed-up references to my fork as a result of this repo temporarily existing on my account before being transferred to the wagtail org...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants