Skip to content

0.0.12#15

Merged
wachawo merged 21 commits into
mainfrom
0.0.12
Oct 18, 2025
Merged

0.0.12#15
wachawo merged 21 commits into
mainfrom
0.0.12

Conversation

@wachawo

@wachawo wachawo commented Oct 18, 2025

Copy link
Copy Markdown
Owner
  • Add check owner and file permissions
  • Add check format file name
  • Increased test coverage

@wachawo wachawo requested a review from Copilot October 18, 2025 22:26
@wachawo wachawo self-assigned this Oct 18, 2025
@codecov-commenter

codecov-commenter commented Oct 18, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.54140% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
checkcrontab/checker.py 95.69% 4 Missing ⚠️
checkcrontab/main.py 95.23% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation for file ownership, permissions, and filename format as part of the 0.0.12 release. It introduces new security checks for system crontab files and validates that cron filenames follow the expected naming conventions.

Key changes:

  • Added file ownership and permissions validation for system crontabs
  • Added filename format validation to reject files with invalid characters
  • Increased test coverage with new test cases for SARIF output, strict mode, exit-zero flag, directory handling, and multiple username support

Reviewed Changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
checkcrontab/init.py Version bump to 0.0.12
docs/CHANGELOG.md Added changelog entry for 0.0.12 release
checkcrontab/checker.py Added check_filename, check_owner_and_permissions, and check_kind functions; refactored daemon check; removed legacy function names
checkcrontab/main.py Renamed generate_sarif_output to gen_sarif_output; added get_files function; integrated filename and permission checks into file processing
tests/test_main.py Removed redundant individual validation tests; updated test file naming from .txt to no extension; added comprehensive tests for new features
tests/test_property_cron.py Updated test filenames from dot notation to underscore notation

Comment thread checkcrontab/checker.py
Comment thread checkcrontab/checker.py
Comment thread checkcrontab/main.py
Comment thread checkcrontab/main.py
@wachawo

wachawo commented Oct 18, 2025

Copy link
Copy Markdown
Owner Author

@codecov-commenter I hate you! :) Thank you

@wachawo wachawo merged commit c4f4011 into main Oct 18, 2025
10 checks passed
@wachawo wachawo deleted the 0.0.12 branch October 18, 2025 23:07
wachawo added a commit that referenced this pull request Nov 3, 2025
Add check owner and file permissions  (Issue #12)
Add check format file name
Increased test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants