Conversation
wachawo
commented
Oct 18, 2025
Owner
- Add check owner and file permissions
- Add check format file name
- Increased test coverage
* check owner and file permissions * check filename
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation for file ownership, permissions, and filename format as part of the 0.0.12 release. It introduces new security checks for system crontab files and validates that cron filenames follow the expected naming conventions.
Key changes:
- Added file ownership and permissions validation for system crontabs
- Added filename format validation to reject files with invalid characters
- Increased test coverage with new test cases for SARIF output, strict mode, exit-zero flag, directory handling, and multiple username support
Reviewed Changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| checkcrontab/init.py | Version bump to 0.0.12 |
| docs/CHANGELOG.md | Added changelog entry for 0.0.12 release |
| checkcrontab/checker.py | Added check_filename, check_owner_and_permissions, and check_kind functions; refactored daemon check; removed legacy function names |
| checkcrontab/main.py | Renamed generate_sarif_output to gen_sarif_output; added get_files function; integrated filename and permission checks into file processing |
| tests/test_main.py | Removed redundant individual validation tests; updated test file naming from .txt to no extension; added comprehensive tests for new features |
| tests/test_property_cron.py | Updated test filenames from dot notation to underscore notation |
Owner
Author
|
@codecov-commenter I hate you! :) Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.