Added ability to forward query strings to tests

[halindrome]

This is an option on the run window to address issue #79

Also cleaned up the option handling and added URL handling for all
of the options on the run page. Added documentation for the URL
parameters to the instructions page.

All changes are backward compatible (in that I did not change any of the
existing names / ids / classes on the controls) just in case someone was
relying upon those.

---

This change is

[jgraham]

I'm not convinced this is a desirable change. The pipes feature is intended for internal usage, and tests may specify their own query string parameters using <meta name="variant"> c.f. https://github.com/w3c/web-platform-tests/blob/78b80c57c5aeb870c6d150adb7e5fae7261826fc/websockets/constructor/001.html#L6

[halindrome]

My thought here was that you would want to start up tests from the URI and pass in parameters that tune the tests. How is data in those meta values made available to tests and can they be manipulated via the URI that is passed in? I think it is really important.

---

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[jgraham]

The idea is that each <meta name=variant> provides a set of possible query strings with which the test can be run. Therefore each test documents which sets of parameters make sense for that test, with each variant forming a separate test and no external input required in order to know what the full set of tests is or run it.

Allowing people to change the test behaviour in an unbounded way seem contrary to that goal.

[halindrome]

The use case would be supplying information to the test - for example a URI
of an endpoint to hit for testing purposes or a username to test with or
something. How would I do that with the existing model?

On Wed, Jul 20, 2016 at 3:38 PM, jgraham notifications@github.com wrote:

The idea is that each provides a set of possible
query strings with which the test can be run. Therefore each test documents
which sets of parameters make sense for that test, with each variant
forming a separate test and no external input required in order to know
what the full set of tests is or run it.

Allowing people to change the test behaviour in an unbounded way seem
contrary to that goal.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#82 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfx8Hv2pjP4YyGN8BSnl8CIr7uTun3Hks5qXocqgaJpZM4Iz2wd
.

Shane McCarron
halindrome@gmail.com