Ignore variation selectors in operator category determination#328
Open
Jules-Bertholet wants to merge 1 commit into
Open
Ignore variation selectors in operator category determination#328Jules-Bertholet wants to merge 1 commit into
Jules-Bertholet wants to merge 1 commit into
Conversation
Ensures that variation sequences in <https://www.unicode.org/Public/ucd/StandardizedVariants.txt> are classified properly.
|
bert-github marked as non substantive for IPR from ash-nazg. |
Author
|
Perhaps what the spec should really say is that any Unicode combining character sequence should be equivalent to its base character. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that variation sequences in https://www.unicode.org/Public/latest/ucd/StandardizedVariants.txt are classified properly. For example, the sequence [U+2295 CIRCLED PLUS, U+FE00] (⊕︀) should have the same lspace and rspace than plain U+2295 CIRCLED PLUS (⊕).
This does not account for the case where a variation selector is followed by U+0338 COMBINING LONG SOLIDUS OVERLAY or U+20D2 COMBINING LONG VERTICAL LINE OVERLAY (resulting in a string of length 3). Further changes would be necessary to handle that edge case.