Clarify updateText behavior when rangeStart > rangeEnd#128
Merged
Conversation
dandclark
approved these changes
Apr 30, 2026
Contributor
dandclark
left a comment
dandclark
left a comment
There was a problem hiding this comment.
Thanks, I agree this is clearer.
We could even go a step further and just delete the note and actually do the swap in the algorithm. Feel free to submit a PR doing that and I'll merge it. :)
Or it's fine to leave as-is, I think it's clear enough now with your edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording in the note about what to do for
updateTextwhen rangeStart > rangeEnd is a bit confusing. I think this should make it a bit clearer :)