Updates deactivate timing for old EditContext#117
Merged
dandclark merged 3 commits intoSep 5, 2025
Conversation
b3f8b55 to
3a5f3e0
Compare
3a5f3e0 to
cb7b93e
Compare
dandclark
reviewed
Sep 4, 2025
3932cbc to
d3043e0
Compare
dandclark
reviewed
Sep 4, 2025
Contributor
dandclark
left a comment
There was a problem hiding this comment.
I think this is mostly ready, just one more stylistic comment.
dandclark
approved these changes
Sep 5, 2025
Contributor
dandclark
left a comment
There was a problem hiding this comment.
Thanks for getting this done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the "deactivate an EditContext" step earlier in the
HTMLElement.editContextreplacement algorithm so deactivation steps (e.g., compositionend) run while the EditContext is still associated with its elementCloses #75
For normative changes, the following tasks have been completed:
Editing WG resolution on the proposed changes, with at least two implementers participating and not objecting:
For browsers that are shipping the feature, implementation bugs are filed for the proposed changes (link to bug, or write "Not Implementing"):