Adding display provider, resource filter and shacl sparql pattern for autocomplete widgets#922
Open
danielbeeke wants to merge 4 commits into
Open
Adding display provider, resource filter and shacl sparql pattern for autocomplete widgets#922danielbeeke wants to merge 4 commits into
danielbeeke wants to merge 4 commits into
Conversation
… autocomplete widgets
TallTed
reviewed
Jun 5, 2026
Comment on lines
+1624
to
+1625
| <p>A <code>shui:DisplayProvider</code> can be attached to a shape to provide custom data fetching for labels, descriptions and other UI elements. This can be done with property shapes | ||
| and also by using SPARQL queries. The fetched data can then be used by widgets such as the <code>shui:AutoCompleteEditor</code> and the <code>shui:EnumSelectEditor</code>. |
Member
There was a problem hiding this comment.
This is what I read the original text to mean. If I'm incorrect -- if a restriction similar to line 1760's for shui:ResourceFilter also applies to shui:DisplayProvider -- my suggestion should not be fully applied, but a variation of line 1760 should be added around line 1627.
Suggested change
| <p>A <code>shui:DisplayProvider</code> can be attached to a shape to provide custom data fetching for labels, descriptions and other UI elements. This can be done with property shapes | |
| and also by using SPARQL queries. The fetched data can then be used by widgets such as the <code>shui:AutoCompleteEditor</code> and the <code>shui:EnumSelectEditor</code>. | |
| <p>A <code>shui:DisplayProvider</code> can be attached to a shape to provide custom data fetching for labels, descriptions, and other UI elements. This can be done with property shapes | |
| and/or by using SPARQL queries. The fetched data can then be used by widgets such as the <code>shui:AutoCompleteEditor</code> and the <code>shui:EnumSelectEditor</code>. |
smessie
approved these changes
Jun 8, 2026
| </tr> | ||
| </table> | ||
|
|
||
| <p>A <code>shui:ResourceFilter</code> MUST use either property shapes or SHACL SPARQL queries. The query is malformed if both or none are present.</p> |
Member
There was a problem hiding this comment.
Would this MUST-requirement also hold for the DisplayProvider? Should it also be made explicit there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #846
As described in #846 we wish to allow using SHACL SPARQL to get autocomplete list items. I searched for a way to also allow standard SHACL to use the shui:ResourceFilter and the shui:DisplayProvider.
Questions: