Skip to content

Fix: Remove some confusing wording regarding all JSON objects being AS2 Object #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trwnh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Remove some confusing wording regarding all JSON objects being AS2 Object #770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40330ab
Fix: Remove confusing wording regarding Object vs Link
trwnh Jun 6, 2026
4499290
Fix: "exception" is not actually an exception
trwnh Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions core/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,21 +627,22 @@ <h2>Model</h2>
</p>

<p>
Every JSON object in an Activity Streams 2.0 document is either an
<code><a>Object</a></code> or a <code><a>Link</a></code>. All other types
defined in the Activity Vocabulary, as well as all extension types, are
derived from these two base types.
All other types

@TallTed TallTed Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying "all" and then immediately proceeding to "one exception" (which implies there are more) is problematic. There might be something better than "Nearly all", like "Virtually all", "With a few exceptions, all", etc.

Suggested change
All other types
Nearly all other types

@trwnh trwnh Jun 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"All other types" is correct"; I guess the real problem is that "One exception" is not really an exception. It's more of a note on disjointness. I'm noticing now that Links is actually already mentioned in the list as the 2nd item.

There is a possibility that the next paragraph may be reworked or removed entirely, as it's part of other issues. I'll remove lines 636-637 to avoid further confusion.

defined in the Activity Vocabulary are
extensions of these base types.
</p>

<p>
The <code>Link</code> base type is disjoint with
the <code>Object</code> base type,
so JSON objects having both types are logical contradictions.
A JSON object in the Activity Streams 2.0 document is a
<code><a>Link</a></code> if either: (a) the object contains a
<code>type</code> property whose value includes "<code>Link</code>" or
(b) any of the types included in the value of the <code>type</code>
property are defined as extensions of <a>Link</a> (see
<a href="https://www.w3.org/TR/activitystreams-vocabulary/#dfn-mention">Mention</a> for
instance); otherwise the JSON object is considered an instance
or extension of <code><a>Object</a></code>.
instance).
</p>

<section id="object">
Expand Down