Skip to content

fix(sdd): preserve unpublished ownership through clarification - #885

Merged
efraespada merged 4 commits into
developfrom
bugfix/856-sdd-ownership-analysis-proposes-registered-path-companion-for-an-explicit-existing-update-request
Nov 4, 2026
Merged

efraespada merged 4 commits into
developfrom
bugfix/856-sdd-ownership-analysis-proposes-registered-path-companion-for-an-explicit-existing-update-request

Conversation

@efraespada

@efraespada efraespada commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Corrige la clasificación entre actualización de un SDD registrado, companion nuevo y capacidad independiente. Tras respuestas autorizadas conserva la propuesta aún no publicada y su ronda, incluso cuando la issue ya tiene una rama de trabajo. Solo la rama enlazada por el registro SDD fija la propiedad publicada; la ruta de un borrador listo sigue usando su fuente correcta. Una aclaración autorizada puede cambiar una propuesta antes de publicar. Se conservan los validadores de propiedad, fuente, autoridad, publicación y diagnóstico seguro.

Closes #856.

Los tres findings de revisión tienen correcciones y regresiones: evaluación semántica explícita de preguntas vinculada al ensayo y respuesta exactos; rechazo de respuestas ausentes antes de consultar preguntas o calcular hashes; y separación entre rama de trabajo y vínculo de publicación SDD. Las propuestas incluyen el significado de su operación registrada y se reconcilian con las respuestas actuales y el catálogo inmutable.

Validación local: 902 suites y 17.704 pruebas de Jest, 35 skips preexistentes y 83 regresiones nuevas; 267 pruebas de extensión con todas las métricas al 100 %. Las 31 líneas modificadas coverables están cubiertas, sin fallos ni parciales, frente a c0e7a13. Tipos, lint, SDD, catálogo, documentación y presupuestos pasan; bundles, paquete de 99 archivos y smoke CLI/API/web pasan. El commit conserva los hooks completos.

La campaña original usa el puerto real del SDK sobre una fuente Git ficticia e inmutable: baseline 19/36, primer candidato 35/36 y revisión 36/36; todos los ensayos y sus fallos se conservan y las preguntas se evalúan explícitamente por el agente, sin atribuir aprobación humana. El suplemento independiente de 15 casos congela los 12 originales y añade tres continuaciones con rama existente. Sus cohortes fueron 14/14/14, 14/15/15 y 15/15/13 sobre 15: las tres se rechazan completas. La versión final obtiene 15/15 en cada uno de tres ensayos, 45/45, cero planes inválidos. No se cambiaron casos, respuestas, modelo, fuente ni criterios entre sus ensayos. La evidencia publica el coordinador usado como texto de auditoría y distingue su preparación del CLI histórico de 12 casos.

Estas mediciones no prueban precisión general ni ejecución completa del consumidor original, cuyos payloads históricos rechazados no están disponibles. El SDD, catálogo y guía explican los contratos, la reproducción y ese alcance. Antes del merge deben pasar los controles del SHA publicado, verificarse explícitamente el tercer finding y quedar todos los hilos resueltos; Codecov oficial debe confirmar 100 % sin parciales frente a la base actual.

…for-an-explicit-existing-update-request: preserve authorized SDD ownership context across clarification
@docs-page

docs-page Bot commented Nov 4, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~885

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 4, 2026 08:05
@vypbot vypbot added this to vypdev Nov 4, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 4, 2026
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 4, 2026
@vypbot
vypbot changed the base branch from develop to master November 4, 2026 08:05
@vypbot
vypbot changed the base branch from master to develop November 4, 2026 08:06
@vypbot vypbot added the 90% Progress: 90% label Nov 4, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on c2c75b9. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 19396c5 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Ownership-question scoring accepts unrelated questions — quality/sdd/ownership-qualification.cjs:84

Comment thread quality/sdd/ownership-qualification.cjs Resolved
@vypbot

vypbot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on c2c75b9.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: c2c75b931298; base: c0e7a130e06f; reason: protected-path.

@codecov-commenter

codecov-commenter commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.50%. Comparing base (c0e7a13) to head (c2c75b9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
+ Coverage    95.49%   95.50%   +0.01%     
===========================================
  Files         1162     1164       +2     
  Lines        38326    38354      +28     
  Branches     11437    11447      +10     
===========================================
+ Hits         36598    36629      +31     
  Misses         665      665              
+ Partials      1063     1060       -3     
Files with missing lines Coverage Δ
...pplication/policies/sdd_ownership_prompt_policy.ts 100.00% <100.00%> (ø)
...ation/usecases/sdd/pre_branch_sdd_gate_use_case.ts 94.40% <100.00%> (+0.48%) ⬆️
src/tooling/sdd_ownership_question_scoring.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…for-an-explicit-existing-update-request: require explicit SDD ownership question assessments

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on c2c75b9. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 42db272 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Handle undefined responses when scoring ownership questions — quality/sdd/ownership-qualification.cjs:85

Comment thread quality/sdd/ownership-qualification.cjs Resolved
…for-an-explicit-existing-update-request: retain invalid ownership responses without crashing

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on c2c75b9. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 4d0810f was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Existing issue branch suppresses the unpublished proposal context — src/application/usecases/sdd/pre_branch_sdd_gate_use_case.ts:185

@vypbot vypbot added 85% Progress: 85% and removed 90% Progress: 90% state:ai-processing labels Nov 4, 2026
…for-an-explicit-existing-update-request: separate working branches from publication ownership
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

70% Progress: 70% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - SDD ownership analysis proposes registered path companion for an explicit existing update request

3 participants