Skip to content

fix(progress): preserve actionable capacity and source diagnostics - #883

Merged
efraespada merged 1 commit into
developfrom
bugfix/851-progress-assessment-rejects-a-39-file-comparison-at-a-fixed-evidence-budget-without-capacity-or-continuation-facts
Nov 4, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/851-progress-assessment-rejects-a-39-file-comparison-at-a-fixed-evidence-budget-without-capacity-or-continuation-facts

Conversation

@efraespada

@efraespada efraespada commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Complete progress capacity failures now preserve the measured boundary and host-proven comparison coverage, so operators can identify the exhausted resource while previous progress remains intact. Supported comparisons retain every source part and receipt through one final assessment.

Fixes #851.

What changed

  • Add a closed, immutable capacity diagnostic with phase, dimension, units, exact/lower-bound/unavailable counts and applicable bounds. Preserve pinned source identity, three path-inventory digests, reconciled coverage, bounded inert path names and original line anchors when independently available.
  • Keep provider failures separate from host planning errors; preserve source diagnostics through the adapter. A raw single comparison cannot claim accepted multipart receipts. All current budgets, independent recovery allowances and publication freshness fences remain.
  • Use shared English/Spanish recovery in terminal, GitHub and public API; align the SDD, catalog and operator documentation with truthful invocation-local continuation.

Validation

  • 899 Jest suites / 17,599 passing tests; 35 preexisting platform skips. All coverage budgets and the acceptance ledger pass; 14 preexisting human setup acceptances remain recorded.
  • 169 new distinct regressions: 99 pure/context, 32 boundary/adapter, 16 workflow, 15 presentation/API, 7 profile/compatibility cases. Four fail before the fix. Controls cover complete comparisons with 39 files and 887 paths, real rejections at 65 parts and a 1024-path manifest, stale sources, provider failure and no partial publication.
  • Six new modules: 100% lines/statements/branches/functions. Full local diff: 239/239 coverable lines, zero misses/partials vs cc43f63; official Codecov and current-head remote review remain required.
  • 267 extension tests at 100% all metrics; build, types, lint, architecture, specifications, docs and workflow contracts pass. Actual 99-file tarball passes CLI/API/web smoke, new declaration closure and seven runtime descriptors.
  • Graphify AST updated; current rollback and four signed Safari test packages retained.

Review notes

The original consumer's failed dimension is unknown. The 39-file review count and later reports do not establish progress coverage or the cause of that original rejection. These SDK regressions qualify known boundaries and complete supported behavior; they are not a consumer rerun.

…d-evidence-budget-without-capacity-or-continuation-facts: preserve capacity and complete-source diagnostics
@docs-page

docs-page Bot commented Nov 4, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~883

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 4, 2026 04:05
@vypbot vypbot added this to vypdev Nov 4, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 4, 2026
@vypbot
vypbot changed the base branch from develop to master November 4, 2026 04:05
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 4, 2026
@vypbot
vypbot changed the base branch from master to develop November 4, 2026 04:05
@vypbot vypbot added the 75% Progress: 75% label Nov 4, 2026
@vypbot

vypbot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 6da035d.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 6da035d1226b; base: cc43f63fcb5a; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (cc43f63) to head (6da035d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #883      +/-   ##
===========================================
+ Coverage    95.46%   95.49%   +0.02%     
===========================================
  Files         1155     1161       +6     
  Lines        38138    38322     +184     
  Branches     11383    11437      +54     
===========================================
+ Hits         36409    36594     +185     
  Misses         665      665              
+ Partials      1064     1063       -1     
Files with missing lines Coverage Δ
...rc/application/errors/progress_capacity_failure.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <100.00%> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...ation/policies/progress_capacity_context_policy.ts 100.00% <100.00%> (ø)
...application/policies/progress_capacity_messages.ts 100.00% <100.00%> (ø)
.../policies/progress_capacity_presentation_policy.ts 100.00% <100.00%> (ø)
...olicies/progress_capacity_source_context_policy.ts 100.00% <100.00%> (ø)
...ication/policies/progress_diff_partition_policy.ts 100.00% <100.00%> (ø)
...tion/policies/progress_evidence_protocol_policy.ts 100.00% <100.00%> (ø)
...tion/policies/progress_partition_receipt_policy.ts 100.00% <100.00%> (ø)
... and 11 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit d546c37 into develop Nov 4, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Progress assessment rejects a 39 file comparison at a fixed evidence budget without capacity or continuation facts

3 participants