Skip to content

fix(sdd): preserve actionable minimum-response failure context - #881

Merged
efraespada merged 1 commit into
developfrom
bugfix/850-undersized-sdd-response-loses-its-drafting-stage-context-behind-generic-retryable-workflow-failed
Nov 4, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/850-undersized-sdd-response-loses-its-drafting-stage-context-behind-generic-retryable-workflow-failed

Conversation

@efraespada

@efraespada efraespada commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Fixes #850.

An SDD draft below the existing 1,800-code-point minimum surfaced as generic retryable workflow.failed. The draft boundary now classifies only the exact typed Markdown minimum rejection and returns nonretryable validation.invalid-input with a closed response-stage cause, minimum and actual host attempt. A discarded adapter response has an explicitly unavailable count; a returned string has a measured Unicode code-point count. The original consumer response, length and provider root cause remain unknown.

The existing preparation card, terminal and API share validated safe facts and English/Spanish recovery guidance. Authors can clarify that the issue requires a complete proposed Markdown document and retry its normal workflow. Rejected content is never published or included in diagnostics. Answers and ownership survive the failed attempt; freshness, source binding, replay and publication fences remain. Maximum/format repair keeps its existing two-query ceiling; minimum, malformed-schema and provider failures authorize no new content repair.

Local acceptance passes: 891 Jest suites / 17,429 tests, with 35 existing skips; 83 new distinct cases against a 40-case budget; and 267 extension tests with all four coverage metrics at 100%. The regressions exercise the real adapter and ordinary Issue/Issue Comment routes, including retained answers/owner, no publication, stale-card protection and owned-card replay. Existing gate/repair fixtures now satisfy the declared minimum while retaining their original assertions. Full-suite LCOV hits 52/52 modified coverable lines without misses or partials against 6bd590da; this is not yet official Codecov evidence.

The focused SDD, primary gate, catalog and operator/error-reference docs are aligned. Types, lint, specification/catalog, documentation/navigation, workflow contracts and AST-only Graphify update pass. Full coverage budgets pass; the 14 preexisting human setup acceptances remain open. The four bundles and public declaration closure are regenerated. The actual 98-file npm tarball passes CLI, typed API and isolated web smoke; a separate tarball fixture checks the new descriptor's types, serialization and invalid-field rejection. These observations do not constitute an original-consumer rerun or live model qualification.

Remote gates remain required for the exact published head and live base: all applicable checks/platforms, complete review with no open findings/threads, and official Codecov 100% modified lines with zero misses or partials. The single base coverage refresh 41750686572 passes at 6bd590da. No release, deployment, schema reduction or review bypass is included.

…ehind-generic-retryable-workflow-failed: retain safe minimum-response diagnostics for undersized drafts
@docs-page

docs-page Bot commented Nov 4, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~881

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 4, 2026 01:21
@vypbot vypbot added this to vypdev Nov 4, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 4, 2026
@vypbot
vypbot changed the base branch from develop to master November 4, 2026 01:21
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 4, 2026
@vypbot
vypbot changed the base branch from master to develop November 4, 2026 01:21
@vypbot vypbot added the 75% Progress: 75% label Nov 4, 2026
@vypbot

vypbot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 8b9b7e1.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 8b9b7e1a5a38; base: 6bd590dac62b; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (6bd590d) to head (8b9b7e1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #881   +/-   ##
========================================
  Coverage    95.45%   95.46%           
========================================
  Files         1155     1155           
  Lines        38098    38138   +40     
  Branches     11357    11383   +26     
========================================
+ Hits         36368    36409   +41     
  Misses         665      665           
+ Partials      1065     1064    -1     
Files with missing lines Coverage Δ
...pplication/errors/sdd_draft_preparation_failure.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...cation/policies/sdd_preparation_message_catalog.ts 100.00% <ø> (ø)
...lication/policies/sdd_preparation_status_policy.ts 100.00% <100.00%> (ø)
...tion/usecases/sdd/pre_branch_sdd_draft_workflow.ts 100.00% <100.00%> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
src/domain/sdd_validation_diagnostic.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit cc43f63 into develop Nov 4, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Undersized SDD response loses its drafting stage context behind generic retryable workflow.failed

3 participants