Repository navigation
fix(sdd): preserve actionable minimum-response failure context - #881
Merged
Conversation
…ehind-generic-retryable-workflow-failed: retain safe minimum-response diagnostics for undersized drafts
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
November 4, 2026 01:21
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #881 +/- ##
========================================
Coverage 95.45% 95.46%
========================================
Files 1155 1155
Lines 38098 38138 +40
Branches 11357 11383 +26
========================================
+ Hits 36368 36409 +41
Misses 665 665
+ Partials 1065 1064 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #850.
An SDD draft below the existing 1,800-code-point minimum surfaced as generic retryable
workflow.failed. The draft boundary now classifies only the exact typed Markdown minimum rejection and returns nonretryablevalidation.invalid-inputwith a closed response-stage cause, minimum and actual host attempt. A discarded adapter response has an explicitly unavailable count; a returned string has a measured Unicode code-point count. The original consumer response, length and provider root cause remain unknown.The existing preparation card, terminal and API share validated safe facts and English/Spanish recovery guidance. Authors can clarify that the issue requires a complete proposed Markdown document and retry its normal workflow. Rejected content is never published or included in diagnostics. Answers and ownership survive the failed attempt; freshness, source binding, replay and publication fences remain. Maximum/format repair keeps its existing two-query ceiling; minimum, malformed-schema and provider failures authorize no new content repair.
Local acceptance passes: 891 Jest suites / 17,429 tests, with 35 existing skips; 83 new distinct cases against a 40-case budget; and 267 extension tests with all four coverage metrics at 100%. The regressions exercise the real adapter and ordinary Issue/Issue Comment routes, including retained answers/owner, no publication, stale-card protection and owned-card replay. Existing gate/repair fixtures now satisfy the declared minimum while retaining their original assertions. Full-suite LCOV hits 52/52 modified coverable lines without misses or partials against
6bd590da; this is not yet official Codecov evidence.The focused SDD, primary gate, catalog and operator/error-reference docs are aligned. Types, lint, specification/catalog, documentation/navigation, workflow contracts and AST-only Graphify update pass. Full coverage budgets pass; the 14 preexisting human setup acceptances remain open. The four bundles and public declaration closure are regenerated. The actual 98-file npm tarball passes CLI, typed API and isolated web smoke; a separate tarball fixture checks the new descriptor's types, serialization and invalid-field rejection. These observations do not constitute an original-consumer rerun or live model qualification.
Remote gates remain required for the exact published head and live base: all applicable checks/platforms, complete review with no open findings/threads, and official Codecov 100% modified lines with zero misses or partials. The single base coverage refresh
41750686572passes at6bd590da. No release, deployment, schema reduction or review bypass is included.