Repository navigation
fix: Bugbot mistakes a source bound nonpersonal UI shell for an authentication bypass (#847) - #876
Merged
Conversation
…-authentication-bypass: ground review in resource contracts and proof boundaries
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
November 3, 2026 18:36
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #876 +/- ##
========================================
Coverage 95.40% 95.40%
========================================
Files 1147 1148 +1
Lines 37985 37989 +4
Branches 11309 11309
========================================
+ Hits 36239 36243 +4
Misses 672 672
Partials 1074 1074
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #847.
A source/session-bound nonpersonal document can intentionally load before human verification. Bugbot now receives one shared resource/authority instruction to inspect emitted content, mandatory source controls, protected API effects and intended availability before calling a missing proof step an authentication bypass.
The instruction reaches ordinary/framed source review, the benchmark and existing Python candidate verification. It preserves actual source-access, protected disclosure, effective-authority and privileged-write defects while respecting permitted nonpersonal bookkeeping. No finding filter, permission, schema, public setting, capacity or historical-resolution rule changes.
The companion SDD, owner/catalog and detection/quality docs are aligned. Eighteen new regressions cover a separate twelve-case fixture group plus six composition/privacy/identity contracts. Explicit LF attributes preserve the probe's exact recorded bytes on Windows; the existing 174-case corpus and 200-case invocation bound are unchanged.
Actual qualification evidence retains all planned trials, earlier candidates, fixture corrections and original scores. The final three-trial sample passes unchanged aggregate thresholds: precision 1, recall 17/18, exact locations 17/17 and correct severity 16/17. All 18 safe observations have no alerts. Trial 1 misses one protected write and overrates one source-access fault; trials 2/3 pass individually. The historical false positive was not reproduced by the current baseline, and its internal cause remains unknown. These are controlled authored Python/SQLite and real SDK/model observations, with no fresh consumer ASGI/browser execution or statistical/general-accuracy claim. Private reference corrections change no reviewer prompt.
Local validation: 880 Jest suites / 17,166 tests pass (35 existing skips), including all 18 new cases; 267 extension tests retain 100% of all coverage metrics. Full-suite LCOV covers 4/4 modified coverable lines, with zero misses/partials versus 2b4a3e7. The pure instruction has one executable statement and no functions/branches, all measured at 100%; no exclusions added. The unchanged setup ledger retains its 14 preexisting human acceptances.
Types, lint, specifications/catalog, documentation/navigation/agent docs, workflow contracts and Graphify pass. Generated bundles and the 96-file package validate; CLI, typed Bugbot API and isolated local web smoke pass. Normal full hooks pass, rerunning build, all 880 suites / 17,166 tests and lint. All 19 prepared input hashes remain identical to the measured source/bundles.
Remote acceptance verified for
a1aa1807ddc22267017b7f45645b91723ec548b8against2b4a3e7537c83141c0e1724f83c75dc3eac9b7c7: CI, Commit, Branch Sync, complete review and Linux/macOS/Windows pass. All three analysis partitions completed, with all context surfaces complete and no omitted/truncated entries, findings or native review threads. Official Codecov confirms 4/4 modified coverable lines, zero misses and zero partials (100%) versus that exact base. Linux/macOS pass 880 suites / 17,166 tests; Windows passes 879 suites / 17,062 tests with platform-specific existing skips. Each native checkout has the exact base/head parents, the candidate tree and one successful deferred-cleanup footer. The Linux artifact records 19 unique actual Firefox ESR extension assertions for that same test merge and exact extension input hash. The advisory protected-path recommendation remains neutral; native develop rules require CI and zero human approvals, and the standing user authorization covers this ordinary merge. No native approval is fabricated or protection bypassed.