Repository navigation
fix: SDD consistency rejects the Unicode C1 designation in prose as a shorthand case ID (#845) - #874
Conversation
…e-as-a-shorthand-case-id: distinguish case references from technical prose
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled oncd6a4da. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit cd6a4da was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Pipes inside code spans split case-reference cells —
src/domain/sdd_case_reference.ts:23
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
|
/copilot recheck |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #874 +/- ##
========================================
Coverage 95.39% 95.40%
========================================
Files 1146 1147 +1
Lines 37904 37985 +81
Branches 11297 11309 +12
========================================
+ Hits 36158 36239 +81
Misses 672 672
Partials 1074 1074
🚀 New features to boost your workflow:
|
Fixes #845.
The SDD validator rejected ordinary Unicode/control and connector designations because it scanned all visible prose for short case-ID spellings. Writers can now keep terminology such as
DEL/C1without changing literal acceptance rows or reciprocal requirement mappings.A pure classifier reuses the existing CommonMark projection to identify case-reference roles, inline labels and table columns. Explicit case references and contiguous case-ID lists remain strict; technical scenario/behavior cells and URI destinations do not acquire a shorthand role just from their spelling. Token boundaries also keep compound designators intact. Canonical identity fields, unknown qualified references, legacy owner reservations/ranges, exact budgets, reciprocal links, immutable paths, repair limits and publication/replay checks retain their existing validation.
The owning SDD, a dedicated companion with 40 literal acceptance cases, generation guidance, catalog and user documentation are updated. A controlled before/after proof invokes the actual approved SDK source with 48 independently authored fixture rows, preserving the rows and reverse links across wording variants. The reference consumer document was read immutably and its Git blob verified; this is not a reconstruction of its historical checkpoint or a claim of consumer implementation execution.
Local validation: 879 Jest suites / 17,148 tests pass (35 existing skips), including 77 distinct new regressions. Extension tests remain 267/267 with every coverage metric at 100%. Full-suite LCOV covers 83/83 modified lines, zero misses or partials against 16bf97f. The classifier measures 100% lines/statements/functions/branches (59 lines / 39 branches), enforced by an exhaustive budget. Regressions exercise real local Git publication/rejection/replay, unchanged owner bytes, bounded draft repair and safe English/Spanish recovery. No settings, permissions, limits or stored-state migration are introduced.
Remote acceptance verified for
cd6a4da2e39cagainst16bf97fff426: CI, Commit, Branch Sync and all three native platforms pass. Linux/macOS pass 879 suites / 17,148 tests; Windows passes 878 suites / 17,044 tests with its existing platform skips. All three test the exact base/head merge and candidate tree, and complete deferred cleanup. Linux Firefox ESR records 19 assertions with the extension actually loaded.The explicit recheck completes 2/2 partitions with all context retained and no omissions/truncations. Its sole earlier finding was disproved using the real validator plus GitHub GFM rendering and explicitly resolved as obsolete; there are zero open/reopened/unverified/unknown findings and no open native threads. Finding verification. Official Codecov confirms 83/83 changed coverable lines, zero misses and zero partials (100%), with both compare SHAs verified.
Types, lint, documentation/SDD/catalog/workflow contracts and Graphify pass. Build and package validation (96 files), CLI/typed API/isolated setup-web smoke and normal commit hooks pass. The hooks reran all 879 suites / 17,148 tests; all 19 prepared input hashes remain unchanged.