-
Notifications
You must be signed in to change notification settings - Fork 7
T7981: conflict check workflow updated to support schedule and workflow dispatch #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dmbaturin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reservations about scripts embedded in YAML. They are hard to execute and debug separately, or run through linters and other tools. Can we move it to a file and call it from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@dmbaturin Created typescript (js) action and script code taken out from workflow |
|
Can you squash 23 commits to some logical sequence?
otherwise it will be not good for commit history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
2bdca7e to
81c0755
Compare
T7981: created scheduling capable reusable workflow for conflict check T7981: created scheduling capable reusable workflow for conflict check T7981: created scheduling capable reusable workflow for conflict check T7981: created scheduling capable reusable workflow for conflict check T7961: conflict label check workflow updated T7981: conflict check updates T7981: conflict check updates T7981: conflict check updates T7981: conflict check updates T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom js action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action T7981: conflict-check-scheduled-workflow updated to use custom ts action
81c0755 to
ee45f32
Compare
Done |
Change Summary
PR Conflict Check Workflow - Updated for Scheduled Execution
Enhanced the PR conflict checking workflow to support scheduled and manual triggers, addressing the issue where GitHub's mergeable state is unreliable immediately after commits.
The scheduled approach will help to solve the issue where immediate post-commit checks don't provide accurate merge status, ensuring comprehensive and reliable conflict detection.
Note:
Corresponding caller workflows will be added in subsequent PRs, with both schedule and workflow-dispatch triggers.
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
Checklist: