Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: vybestack/llxprt-code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenCodeReview — automatic reviews suspendedAutomatic OCR reviews are suspended for this PR after 2 of 2 automatic reviews. To get more reviews you can:
|
LLxprt PR Review unavailableThe walkthrough pipeline could not complete. Please inspect the workflow logs. |
|
Hosted pilot run 36265295571, head A separate diagnostics bug prevented deeper attribution: upload-artifact rejects |
|
Hosted pilot run 36278157447 at The intended pilot-only 600,000 ms watchdog did not take effect for the attempts reporting 300,000 ms. Compared with run 36276039788, shell still passes in both legs; the longer rig deadline now exposes wrong-tool behavior alongside the unchanged first-response timeouts rather than making replace pass. Both diagnostic artifacts uploaded: host and Docker, with Ollama logs, model ledger, and TestRig telemetry. Observed replace prompts reached about 18,064 tokens, below the configured 32,768 context; Ollama reported no truncation. Final snapshots: host 10 GiB RAM available / 81 GiB disk free; Docker 10 GiB / 78 GiB; neither job approached the 90-minute job cap. Qwen3.5:2b Q8_0 digest |
Hosted Gemma pilot: five-minute timeout traced to the HTTP transportI inspected the downloaded host and Docker artifacts for run 36283740686, the installed OpenAI/Undici sources and the pilot/test-rig settings. No code, assertions or required checks changed in this investigation; HEAD remains
Recommended test-first change, not applied: Add a Bun integration-style test against a delayed-header local HTTP server that exercises the real OpenAI client factory and verifies that a scoped, explicitly configured transport headers deadline longer than the delay succeeds while an unconfigured client keeps its usual behavior. Carry that opt-in transport setting through the pilot profile, and set its headers deadline above the 600,000ms first-response watchdog; do not alter the global Undici dispatcher or loosen normal provider defaults. Separately, give only the pilot shell TestRig a CPU-justified deadline (at least enough for the observed ~238s response plus the tool round trip), with a Bun test proving non-pilot deadlines remain unchanged. Re-run local canaries and targeted tests before one further opt-in hosted pilot, keeping exact |
|
Hosted Gemma pilot run 36289820501 at Host diagnostics confirm HTTP 200 for replace after 541.375 s, a successful This is a hosted host-leg success, not the repeated two-leg result required for promotion. Next bounded experiment: test a pilot-only first-response watchdog increase to 750,000 ms (below the existing scoped 900,000 ms transport deadline), leave the strict shell/replace assertions and budget unchanged, then run one opt-in hosted host/Docker pilot. Keep #3764 open, this PR draft and the pilot non-required. |
Same-SHA hosted repeat and E2E parity, #3764The repeat opt-in run 36295275993 succeeded on
Both used verified Ollama 0.31.1 and Gemma 4 Parity before any full migration: The credentialed path selects the provider/model/base URL via A safe migration would provision and pin Ollama in the full host/Docker matrix, retain the exact 31-file invocation plus three shell cases, existing assertions, budget guard, doc-only/fork/mergeability logic, check context names and required-check enforcement, and prove this larger suite works within the chosen job budget. Do not replace the full suite with the two pilot canaries or silently apply |
Opt-in full-selected run 36314643244: both legs pass, Intel backend still unmeasuredAt CPU/backend: The Docker Ollama server identifies AMD EPYC 9V74 80-Core Processor, with Selected tests and tools: Each leg passed 31/31 isolated selected files (zero failed files), then 3/3 selected shell cases (12 other shell cases filtered out). Docker replace passed on its first file attempt in 414.257 s, host in 648.571 s. Both artifact TestRig diagnostics show exact Budget/retries/resources: Both budget steps passed: 4/4 distinct-test model API requests, ceiling 4, historical baseline 9, split two replace/two real shell per leg. Each ledger has one replace test record and one real-shell test record: no selected canary file retry is observed. Each also has four zero-request Promotion decision: Keep this PR draft and pilot opt-in/non-required. On an actual Intel Docker runner, first require the pre-test warm-up and positive live |
|
Implementation update for #3764: commit |
9899392 to
c78779b
Compare
Bounded backend correction: hosted outcomeThe Intel diagnostic correction was pushed to The first dispatch after the implementation push, 36320244031, resolved to the old SHA Focused Bun tests: 17 passed, one Linux-only test skipped on macOS, zero failed; focused workflow actionlint passed. Typecheck, build and test audit passed in the initial full cycle. The full local test suite did not pass: two runs each failed one unrelated CLI file ( |
Final status for issue #3764 at
|
Final verification correctionThe final pushed SHA is The final local full Full local lint, typecheck, format, build, focused workflow actionlint, and test-audit passed. Full repository actionlint still reports three findings in unchanged The permitted pilot repeat run 36321643875 passed both legs at earlier SHA PR #3765 remains draft and is not ready to claim complete Intel hardware proof. |
|
The single opt-in x64 pilot at
Local focused tests (22 passed, one Linux-only skip), full |
Runner-local E2E cleanup (Refs #3764)
At
e3a442dbe, the existing ordinary Linux E2E job/check name is preserved as the single runner-local Gemma route. The optional pilot job andpilot_local_modeldispatch input are removed. Manualworkflow_dispatchwithbranch_refruns the same real host and Docker E2E legs; pushes tomainrun the host leg only. The renamed local profile, timeout flag and labels describe this one route without changing ordinary provider settings.The latest ordinary PR E2E run 36377286727 passed on both host (job 108785708956) and Docker (job 108785708975). Both runners were AMD. Each leg covered 31/31 selected files and three selected shell cases, including the real
echo hello-worldtool and exactbar contentreplacement. Host replacement passed on its second file attempt; Docker passed on its first. The unchanged 4/4 request budget counts distinct tests, not total transport retries.CI run 36377286242 passed Lint, Test, CodeQL and Actions lint. It has no optional pilot job or skipped matrix label. The earlier pilot run 36342130687 passed Intel Docker with a Haswell pin at an older SHA; it does not prove Intel repeatability at this SHA.
Ollama 0.31.1 is pinned to archive SHA-256
d297381efc136451f6fabb9dd644a67f70fe51c16815a0c4a95ff0e327a3afb4; Gemma is pinned to digest07ea59a474013479c8b6b802bef095c40e964a1d776ba02f264c0e30e1aede0c. Historical todo-continuation and shell-case exclusions remain unchanged. Credentialed provider-specific E2E remains nightly, and normal PR runs receive no model-provider key. Fork PR heads remain outside the privileged target path.Local verification at
e3a442dbepassed: tests, lint, typecheck, build, formatting, actionlint and test audit. The PR remains draft. The botRun LLxprt reviewcheck is still running after a previous instance timed out; no approval or completion is claimed.