Skip to content

fix(client): avoid retaining onContentUpdated callbacks during ssr #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mister-Hope merged 1 commit into from
Sep 27, 2026
Merged

fix(client): avoid retaining onContentUpdated callbacks during ssr #1722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/client/src/composables/onContentUpdated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ import type { ContentUpdatedCallback } from '../types/index.js'
* in the DOM.
*/
export const onContentUpdated = (fn: ContentUpdatedCallback): void => {
// callbacks are only invoked on client side, and components are never
// unmounted in ssr, so skip registering to avoid retaining them forever
if (__VUEPRESS_SSR__) return

contentUpdatedCallbacks.add(fn)
onUnmounted(() => {
contentUpdatedCallbacks.delete(fn)
Expand Down
Loading