Repository navigation
worker: each briefing asks agents to check up to two claims: disputed, or often read and not confirmed lately - #89
Conversation
…ted claims before LIMIT
…-ghkdsb # Conflicts: # docs/features/hosted-worker.md # worker/src/mcp.ts # worker/src/memory.ts
…eedback as what accepts
…lines capped at 3
…, or often read and not confirmed lately
|
The Python Generated by Claude Code |
vu1n
left a comment
There was a problem hiding this comment.
VPS review of 93cacf3: 1 finding(s), 1 blocking.
The change adds briefing checks for disputed and frequently shown stale claims. One confirmed selection bug can hide eligible disputes, so it should be fixed before merging.
1 finding(s) dropped by the check
worker/test/check.test.ts:40Test expiry and read-only feedback through the new check flow: Missing regression coverage does not demonstrate a defect: toCheck compares lastUsed against the 30-day cutoff, and checkedness counts only feedback explicitly marked writable, which read-only callers cannot produce.
| project ? store.recentCandidates(project, ctx.session, RECENT) : [], | ||
| // User scope is how this person works, read from every repo; unconfirmed lessons stay labelled and apart. | ||
| user ? store.recentUserCandidates(user, ctx.session, RECENT_USER) : [], | ||
| store.recall("", project, user, { candidates: "none", groups, limit: CHECK, disputed: true }), |
There was a problem hiding this comment.
P2 Exclude the session's own disputes before applying the query limit
If the two highest-ranked disputed claims belong to the current session, the query returns only those two and toCheck removes both. Other eligible disputes are never considered, and stale accepted claims can take their slots despite the disputed-first rule. This affects both repo and room briefings. Apply the session exclusion in SQL before LIMIT, or fetch further eligible disputes after filtering, and add a regression test.
A briefing now ends its claim sections with "# check these if your work touches them, then rate them with
feedback", holding at mostCHECK(2) claims: disputed ones first, then accepted claims shown at leastCHECK_SHOWN(10) times with no writableusedinCHECK_DAYS(30). A disputed claim reaches a briefing only there. A writableusedtakes a claim back off the list. The section shares the briefing's size budget and is recorded under sectioncheck.Why: memory goes stale silently; asking the sessions that read a claim to confirm it is the cheapest recheck.
Contracts touched: briefing output (new section);
store.checkedness(ids).Verification:
npm run typecheck;npm test393/393; newtest/check.test.ts;featuremap.py checkclean.Generated by Claude Code