Repository navigation
worker: a used rating from another session confirms a candidate - #80
Conversation
vu1n
left a comment
There was a problem hiding this comment.
VPS review of 73a481f: 3 finding(s), 3 blocking.
The change allows writable sessions’ used feedback to support candidate promotion. It is not safe to merge yet: legacy read-only ratings can count, withdrawn feedback can survive planning, and tied timestamps can select the wrong verdict.
vu1n
left a comment
There was a problem hiding this comment.
VPS review of d217415: 2 finding(s), 2 blocking.
The change lets writable used feedback confirm candidates and explains this in echo replies. Two confirmed defects allow withdrawn support to promote claims and cause duplicate cleanup to discard support needed for promotion, so fixes are needed before merging.
vu1n
left a comment
There was a problem hiding this comment.
VPS review of 09ce750: 1 finding(s), 1 blocking.
The change allows writable used feedback to confirm candidate claims. It is unsafe to merge because feedback can bypass project write restrictions by reusing a session across credentials.
…when a claim is an echo
d620108 to
56b4599
Compare
vu1n
left a comment
There was a problem hiding this comment.
VPS review of 56b4599: 0 finding(s), 0 blocking.
The change allows writable feedback from another session to count toward claim recurrence while preserving stamped candidates beneath echoes. The reported test gap does not establish a defect; based on this finding, the change is safe to merge.
1 finding(s) dropped by the check
worker/test/confirm.test.ts:133Test the S1 hold with feedback-backed recurrence: Feedback-backed promotions still pass through planWithJudge's S1 disagreement check, which replans with autoAccept disabled, and planGroup then preserves the stamped candidate beneath the higher-ranked echo; the missing combined test demonstrates no functional failure.
vu1n
left a comment
There was a problem hiding this comment.
VPS review of d7c45b0: 1 finding(s), 1 blocking.
The change lets writable used feedback confirm candidate claims, but incorrectly excludes rooms from confirming claims in linked repositories they can write to. This permission mismatch should be fixed before merging.
vu1n
left a comment
There was a problem hiding this comment.
VPS review of a4b5857: 1 finding(s), 1 blocking.
The change lets writable sessions confirm candidate claims through used feedback. A room-link authorization race can record a confirmation after write access is removed, so this should be fixed before merging.
vu1n
left a comment
There was a problem hiding this comment.
VPS review of 443cd2f: 1 finding(s), 1 blocking.
The change lets writable used feedback count toward candidate promotion and adds a guard against withdrawn confirmations. A confirmed timestamp-fencing gap can still allow promotion without the required recurrence interval, so it should be fixed before merging.
Requested by Vu · project thread
Why: in production, 11 of the 15 subjects that ever reached a second session never promoted, only because every later session had been shown the candidate first, so the echo guard gave its re-claim no credit (34 such claims, all different sessions, mostly days apart). Nothing a reader did could count. Diagnosis:
research/kypp-promotion-diagnosis-2026-11-06.mdin the project files.Contract
recurscounts eachusedrater as that session's support at the rating's time, soKYPP_RECUR_GAP_MINUTESand the S1 agreement hold still apply. A claim's writer never confirms it.consolidateloads, per live candidate, sessions whose newest feedback row is ausedmarkedwritable(store.confirmations); ties break onrowid. A laternot_used/wrong(any token) withdraws it.feedbackmarks a ratingwritableonly when the current caller could write at the claim's level (mayWrite): not read-only, inside its pin, its own user/room lane. Unmarked and pre-existing rows never confirm.GroupPlan.confirmed);applyrefuses the plan if any was withdrawn since.echo:line pointing atfeedback;initializesteps say ausedfrom another session confirms.Verification
npm test: 365 pass, includingtest/confirm.test.ts(echo reply, used promotes, writer/read-only/pinned-elsewhere/withdrawn don't, fence on withdrawal, ties, echo keeps the rated claim, gap). Mutations of the wiring, fence, writable check and lane check each fail a test.npm run typecheckclean;featuremap.py check0 broken pointers.Merging deploys to kypp.vu1n.dev.