Repository navigation
ci: read-only token by default; fork PRs never on the self-hosted runner - #102
Merged
Merged
Conversation
Each workflow now declares contents: read, so none depends on the repo's default token permissions. python.yml could run a fork's PR on the netcup runner when RUNNER_LABEL is set; it now uses a hosted one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vu · project thread
Hardening after the wfx credential-theft campaign.
python.yml,worker.ymlandrelease.ymldeclarepermissions: contents: readat the top.release.yml's deploy job still grants itselfcontents: writeandid-token: write. This way, setting the repo default to read-only breaks nothing.python.ymlpicks thenetcupself-hosted runner whenvars.RUNNER_LABELis set. A fork PR would then run its code on our host. Fork PRs now always useubuntu-latest.Not a worker change, so it deploys nothing. YAML parses. CI on this PR exercises both workflows.
Generated by Claude Code