Skip to content

uzi self-improvement - #4472

Open
vtmocanu-uzi wants to merge 4 commits into
mainfrom
uzi/self-improve/bfbb675e-8473-4859-8446-1c8be84d96cd
Open

vtmocanu-uzi wants to merge 4 commits into
mainfrom
uzi/self-improve/bfbb675e-8473-4859-8446-1c8be84d96cd

Conversation

@vtmocanu-uzi

@vtmocanu-uzi vtmocanu-uzi commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Caveat-only code cross-check results no longer give the lead a repair turn. When every finding's title starts exactly with Coverage uncertainty:, the check finalizes at once and each caveat is recorded as not reported. The checker still cannot see gate or command logs, so the evidence gap itself is unchanged.

Size: 8 files

Category Added Deleted
Code +8 −2
Tests +30 −0
Docs +28 −3
Generated +4 −1
Total +70 −6

What changed

  • When every code cross-check finding has a title starting exactly with Coverage uncertainty:, the lead gets no repair turn and the check finalizes immediately.
  • Any graded finding, including a Requirement gap:, still gives the lead one repair turn for the whole report.
  • Caveats appear in the merge request as not reported, matching the checker brief's description of checks it cannot perform.
  • Cross-check docs, the embedded docs mirror, ARCHITECTURE.md, specs/human.md and ADR-2149 describe the new rule; a changelog fragment is added.

Code cross-check repair decision

flowchart LR
  n1["Code checker reports findings"] --> n2["Every finding a Coverage uncertainty title"]
  n2["Every finding a Coverage uncertainty title"] -->|"yes caveats only"| n4["Finalize caveats recorded as not reported"]
  n2["Every finding a Coverage uncertainty title"] -->|"no a graded finding is present"| n3["Lead gets one repair turn"]
  n3["Lead gets one repair turn"] -->|"lead reports dispositions"| n4["Finalize caveats recorded as not reported"]
Loading

Verification

Reported by the agent at acf76e4:

  • passed: UZI_DEADCODE_AGENT_REQUIRED=1 task check:agent
  • passed: node --import tsx --test --test-timeout=120000 test/code-cross-check-repair.test.ts (candidate: 25/25)
  • failed: same file against base d043970 gate in a scratch export (regression red: the 2 new caveat-only tests fail)
  • passed: node --import tsx --test --test-timeout=120000 test/code-cross-check-wire.test.ts
  • passed: node --import tsx --test --test-timeout=120000 test/pr-description.test.ts
  • passed: cd api && go test ./internal/uzidocs -run TestEmbeddedDocsMatchSource -count=1
  • passed: task check-docs:web
  • passed: task check:changelog-entry
  • passed: task check:token-literals
  • passed: git diff --check HEAD

Scope and review notes

  • Changed: Reduces only the wasted iteration for caveat-only findings. The checker still does not see gate, command or scratch-log evidence, which stays parked per the existing PRD decision.
  • Dropped: The ask's other recommendations are not addressed: background task loss handling, repo instruction access for the checker, environmental test failures, checkpoint publication diagnostics, worker mi…
  • Added: ARCHITECTURE.md's cross-check paragraph was updated although the plan did not name it, after a reviewer flagged the old sentence as stale.
  • Deferred: Reviewer note: matching is on title only, so a caveat marked major or critical, or a mis-prefixed defect, also skips the repair and shows as not reported. This is recorded in ADR-2149 as a delibera…
  • Deferred: Minor doc and test nits from review were deferred: no second-done assertion in the new test, prose wording of 'nothing to fix', no explicit exact-prefix wording in one doc, one long line, and best-…
  • Review: agent/src/code-cross-check-gate.ts, done(): the added every(...) clause on the repair condition. The match is exact and case-sensitive on the title, so a caveat marked major or critical still skips…
  • Review: The reported test results are the agent's own claims. The base-commit run of the new caveat tests is reported as failing, as expected for new behaviour, and exact-head CI has not run.

Describes acf76e4 against main.

Autonomous self-improvement change (PRD #46), one top improvement per cycle. Tracking issue: #296 (a stable container this PR never closes).

Internally reviewed by the repository's own agents, not uzi's built-in reviewer.


Self-improvement run

Test evidence (run by the worker before the push; the PR's own CI is separate):

  • ✅ api: go test ./... — passed (exit 0)
  • ✅ web: npm test — passed (exit 0)
  • ✅ web: npm run build — passed (exit 0)
  • ✅ agent: npm run typecheck — passed (exit 0)
  • ⚠️ agent: npm test — skipped (timed out)

⚠️ 1 of 5 checks were SKIPPED — skipped is NOT passed.
Those suites did not run here (the worker lacks the toolchain or the freshly cloned
worktree has no installed dependencies), so this MR carries NO evidence for them.
Their proof must come from the PR's required exact-head CI before merging.

The bot cannot merge to main (protected-branch merge rights are humans only). A human must review and merge.

Code cross-check (checked acf76e4, Codex gpt-6.1-sol · high)
1 finding: 0 graded (0 addressed, 0 declined), 1 verification caveat (0 addressed, 1 declined)
No graded findings; verification caveats are not a certification that the change has no defects.
Coverage: 8 examined, 0 excluded, 0 unassessed
Coverage is an advisory review account.
Verification caveats (evidence the read-only checker could not verify; a disposition never marks a criterion met or waives a landing obligation):

  • C1 · minor · agent/test/code-cross-check-repair.test.ts:216 · Coverage uncertainty: execution and landing criteria remain unverified — declined: This is a verification caveat, not a defect: the checker itself says it identifies no implementation defect, and no code change can r​esolve it. The in-run checks ran with logs under .uzi/scratch: red on a base export (gate-log.quAJeS, 23 pass / 2 fail, EXIT=1); green on the candidate (gate-log.7wwdEi, 25/25); and the tester's gate run on c1fcb93 (check:agent BIcNOf, repair test UuiCwD, wire test caDL79, pr-description test Bu7NDg, uzidocs embed test 4EDXTx), all EXIT=0. The full agent suite and API embed jobs stay a declared landing obligation for exact-head PR CI. This caveat-only report is exactly the case the change stops from opening a repair turn; this worker still runs the old code.
    Changes after the check were not cross-checked.

Opened by uzi from uzi/self-improve/bfbb675e-8473-4859-8446-1c8be84d96cd. A human reviews and merges; uzi never merges.

Summary by CodeRabbit

  • Bug Fixes
    • Code cross-checks now skip the repair step and finalize immediately when all findings are coverage uncertainty caveats. These caveats are marked “not reported.”
    • Findings that include other types of issues continue through the existing repair flow.
  • Documentation
    • Updated cross-check guidance to describe this behavior.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between acf76e4 and 87e4bbc.

Files selected for processing: 8

  • ARCHITECTURE.md
  • adr/2149-cross-check.md
  • agent/src/code-cross-check-gate.ts
  • agent/test/code-cross-check-repair.test.ts
  • api/internal/uzidocs/embed/cross-check.md
  • changelog.d/9640b59a-cf90-4726-8a23-b1e95ba6f7b3.md
  • docs/cross-check.md
  • specs/human.md

No actionable comments were generated in the recent review.

Walkthrough

The code cross-check gate skips its repair turn when every finding title begins exactly with Coverage uncertainty:. It finalizes through the existing empty-dispositions path, which records each finding as not reported. Other findings retain the repair turn.

Changes: Code cross-check repair decision

Layer / File(s) Summary
Caveat-only repair decision
agent/src/code-cross-check-gate.ts, agent/test/code-cross-check-repair.test.ts, ARCHITECTURE.md, adr/2149-cross-check.md, api/internal/uzidocs/embed/cross-check.md, docs/cross-check.md, specs/human.md, changelog.d/9640b59a-cf90-4726-8a23-b1e95ba6f7b3.md
The gate skips repair when every title starts with the exact Coverage uncertainty: prefix. Tests cover caveat-only findings and cases that still activate repair. Documentation describes the skip and not-reported finalization.

Possibly related issues

Possibly related PRs

  • vtmocanu/uzi#4120: Adds Coverage uncertainty: notes that this change recognizes when deciding whether to start repair.

Suggested reviewers: vtmocanu

Change: Feature

Merge Risk: Minimal · previous review acf76

Code cross-check reports made up only of coverage-uncertainty caveats now finalize without a repair turn, and the caveats show as not reported. Any other finding still gets the repair turn. The change is small, covered by new tests, and documented, so merge risk is minimal.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "uzi self-improvement" is vague and generic. It does not name the change. The PR changes code cross-check handling so that caveat-only findings (titles starting with Coverage uncertainty:)… Rename the PR to describe the primary change, for example: "Skip code cross-check repair turn for coverage-uncertainty caveats". Keep it short and specific.
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "uzi self-improvement" is vague and generic. It does not name the change. The PR changes code cross-check handling so that caveat-only findings (titles starting with Coverage uncertainty:) skip the lead's repair turn and finalize immediately with caveats recorded as not reported. The title gives no hint of this behavior, so a teammate scanning history cannot tell the main change.

Resolution

Rename the PR to describe the primary change, for example: "Skip code cross-check repair turn for coverage-uncertainty caveats". Keep it short and specific.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d043970 and acf76e4.

Files selected for processing: 8

  • ARCHITECTURE.md
  • adr/2149-cross-check.md
  • agent/src/code-cross-check-gate.ts
  • agent/test/code-cross-check-repair.test.ts
  • api/internal/uzidocs/embed/cross-check.md
  • changelog.d/9640b59a-cf90-4726-8a23-b1e95ba6f7b3.md
  • docs/cross-check.md
  • specs/human.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 19, 2026
vtmocanu and others added 2 commits November 19, 2026 09:29
…l caveat-titled findings still get the repair

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants