Skip to content

Admin → Instance overflows horizontally at 400px: Trusted repositories fieldset does not shrink - #4433

Open
vtmocanu-uzi wants to merge 2 commits into
mainfrom
agent/issue-4428
Open

vtmocanu-uzi wants to merge 2 commits into
mainfrom
agent/issue-4428

Conversation

@vtmocanu-uzi

@vtmocanu-uzi vtmocanu-uzi commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

The Docker worker repo allowlist's "Trusted repositories" list no longer stretches the page at a 400px width. Long repository paths, owner emails and hosts now end in an ellipsis instead of widening the card, so the page stops scrolling sideways. Selection, save, locked state and masking are unchanged.

Size: 3 files

Category Added Deleted
Code +5 −5
Tests +61 −0
Docs +4 −0
Total +70 −5

What changed

  • The Trusted repositories group shrinks to the width of its card instead of its longest row.
  • Each repository row truncates its path and its owner · forge · host line with an ellipsis.
  • The checkbox and the Disabled badge are marked to keep their size.
  • A browser test renders the card at 400px with very long repository values and checks that neither the page nor the list box scrolls sideways.
  • A changelog fragment is added under Fixed.

Verification

Reported by the agent at 8e2732a:

  • failed: cd web && npx vitest run --config vitest.browser.config.ts src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx (without the fix)
  • failed: same test with only the fieldset min-w-0 applied (list box still overflowed 1248 > 356)
  • passed: cd web && npx vitest run --config vitest.browser.config.ts src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx (with the fix)
  • passed: cd web && npx vitest run src/pages/AdminSettings.test.tsx
  • passed: task check:web
  • passed: bash scripts/changelog-fragments.sh validate <fragment>
  • passed: git diff --check HEAD

Scope and review notes

  • Changed: The issue names Admin → Instance, but the plan context says the card moved to Admin → Workers. The fix is in the card itself, so it applies wherever the card renders. The Admin → Instance pag…
  • Added: The Disabled badge also gets shrink-0. The issue did not list this change.
  • Review: The checkbox-width and Disabled-position assertions may not catch a missing shrink-0 on their own, because flex minimum sizing already keeps a 16px input and a short badge at size. The page and lis…
  • Review: The owner · forge · host line now truncates instead of wrapping, and there is no title tooltip to reveal the hidden text.

Describes 8e2732a against main.

Related to #4428.

Closes #4428

Internally reviewed by the repository's own agents, not uzi's built-in reviewer.

Code cross-check (checked 8e2732a, Codex gpt-6.1-sol · high)
2 findings: 0 graded (0 addressed, 0 declined), 2 verification caveats (1 addressed, 1 declined)
No graded findings; verification caveats are not a certification that the change has no defects.
Coverage: 3 examined, 0 excluded, 0 unassessed
Coverage is an advisory review account.
Verification caveats (evidence the read-only checker could not verify; a disposition never marks a criterion met or waives a landing obligation):

  • runtime_verification · minor · web/src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx:26 · Coverage uncertainty: required execution results cannot be verified here — addressed: No code defect; this is a request for execution evidence, and the run executed every required check. The logs are in .uzi/scratch. Browser test on the unfixed component: EXIT=1 (scrollWidth 2665 > 400), red-log.ype4qW. Fieldset-only f​ix: EXIT=1 (list box 1248 > 356), partial-log.wYp4zq. Full f​ix: EXIT=0, green-log.90dz50. AdminSettings.test.tsx, 120 passed: EXIT=0, jsdom-log.MPg2M9. task check:web: EXIT=0, gate-log.dPLqLw. changelog-fragments validate: rc=0. git diff --check HEAD: rc=0. All ran against the tree committed as 8e2732a; there are no further changes.
  • exact_head_ci · minor · web/src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx:0 · Coverage uncertainty: exact-head full-suite CI remains external — declined: By design. The issue and the approved plan put full test:web, test:web-browser and gate:repo under Landing obligations on exact-head PR CI. They cannot run as a code change in this run, and the plan does not claim them as passed. They are recorded as deferred in the PR scope notes.
    Changes after the check were not cross-checked.

Opened by uzi from agent/issue-4428. A human reviews and merges; uzi never merges.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the Docker repository allowlist layout on narrow screens. Long repository paths, owner emails, host details, and disabled-status text now truncate with an ellipsis instead of widening the page. Checkboxes remain visible and usable.
    • Added coverage to verify the allowlist stays within a 400px-wide viewport without horizontal scrolling.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Docker worker repository allowlist now truncates long repository details on narrow screens. A browser test checks the layout at a 400px viewport.

Changes: Docker allowlist narrow-screen layout

Layer / File(s) Summary
Constrain and verify repository rows
web/src/pages/adminSettings/DockerAllowlistCard.tsx, web/src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx, changelog.d/1852f286-ba56-4bd9-972c-9631d8b2aaae.md
The fieldset and repository row text can shrink, and long values are truncated. The browser test checks viewport containment, horizontal overflow, and checkbox width at 400px. The changelog records the fix.

Suggested reviewers: vtmocanu

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · up to 24403

This change keeps long repository paths and owner/host text from widening the page at narrow widths. It is a CSS-only fix with a regression test, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the Admin → Instance page and the Trusted repositories fieldset not shrinking at 400px. The changeset makes the repository fieldset min-w-0, adds truncating text spans and shrink-saf…
Linked Issues check Passed Directly linked issue #4428 has coding requirements for DockerAllowlistCard. Diff of web/src/pages/adminSettings/DockerAllowlistCard.tsx from merge base 908b978 to head 24403e2 shows: (1) the Trusted …
Out of Scope Changes check Passed All changes map to #4428 or to supporting work. The component diff is limited to the Trusted repositories fieldset and its row elements in DockerAllowlistCard.tsx. The shrink-0 on the Disabled badge i…
Full details: Title check

Explanation

The title names the Admin → Instance page and the Trusted repositories fieldset not shrinking at 400px. The changeset makes the repository fieldset min-w-0, adds truncating text spans and shrink-safe checkboxes in DockerAllowlistCard, and adds a 400px browser regression test. The title is specific and matches the main change. It is long (95 characters) and names the page where the card renders, which the PR objectives note may differ from where the card lives, but the title still describes the real fix.

Full details: Linked Issues check

Explanation

Directly linked issue #4428 has coding requirements for DockerAllowlistCard. Diff of web/src/pages/adminSettings/DockerAllowlistCard.tsx from merge base 908b978 to head 24403e2 shows: (1) the Trusted repositories <fieldset> gains min-w-0 (issue: fieldset must shrink to its container); (2) the path span keeps truncate and gains min-w-0; (3) the owner · forge · host span gains min-w-0 truncate; (4) the checkbox gains shrink-0 (issue: checkbox keeps its size). The diff changes only class names. Selection, toggle, save, locked state, and maskRepoPath/maskEmail/maskHost calls are unchanged. The regression requirement is covered by the added browser test in DockerAllowlistCard.browser.test.tsx (per the PR summary, it asserts document, fieldset, and Disabled label stay within a 400px viewport with long values, and that the list does not scroll horizontally). The PR summary reports that this test failed without the fix and passed with it, and that AdminSettings.test.tsx and task check:web passed. I did not re-run these tests and did not inspect the test file body, so the test evidence rests on the reported results and summary. Full test:web, test:web-browser, and gate:repo are deferred to exact-head PR CI by the issue, so they are not counted here.

Full details: Out of Scope Changes check

Explanation

All changes map to #4428 or to supporting work. The component diff is limited to the Trusted repositories fieldset and its row elements in DockerAllowlistCard.tsx. The shrink-0 on the Disabled badge is not named in the issue. It sits in the same row and applies the same size-preserving intent as the checkbox change, so it is a minor connected addition, not an unrelated change. The owner line now truncates instead of wrapping, as the issue requires. The changelog fragment and the new browser test support the fix. No other Admin → Instance cards, the #4419 tab row or section pills, or allowlist semantics were changed in the reviewed diff. The head differs from the commit named in the PR description (24403e2 vs 8e2732a). The component diff at head matches the described changes, so no evident post-check drift was found in that file. Other files were not diffed.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 908b978 and 24403e2.

Files selected for processing: 3

  • changelog.d/1852f286-ba56-4bd9-972c-9631d8b2aaae.md
  • web/src/pages/adminSettings/DockerAllowlistCard.browser.test.tsx
  • web/src/pages/adminSettings/DockerAllowlistCard.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin → Instance overflows horizontally at 400px: Trusted repositories fieldset does not shrink

2 participants