Repository navigation
feat: selectable themes, theme chooser, and line-1 refinements - #15
Conversation
Darken Synthwave's magenta, purple, and cyan gradient stops so phone service glyphs and wide peer/update text remain readable. Across the gradient, minimum white/cyan/yellow/pink contrast improves to 12.26/7.06/7.76/3.39:1. Keep the neon caps and status foreground hues. Brighten dim text in seven themes so held context and empty bars remain readable while staying secondary to live percentages. Give Synthwave idle peers a subdued accent. Use code/my-project in chooser previews for a stable sample folder label. One UX reviewer inspected 189 real renders, including all service states, phone/wide layouts, peers, updates, dirty branches, cache inversion, and transcript-proven held context. No glyph changes were recommended. Validation: task ci passed 963 checks and 75 fetcher checks in each locale; task test-themes-full passed 1681 checks in each locale. Unset/default/ unknown theme snapshots each matched all 108 original baseline renders.
|
@coderabbitai review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (13)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe renderer now supports selectable themes, appearance-aware resolution, updated session-title and peer-count behavior, and theme-specific statusline rendering. A new command lists, previews, and saves themes. The installer stages Git archives through a temporary file. ChangesStatusline themes and display
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
actor User
participant ThemeCommand as cc-statusline-theme
participant Renderer as statusline.sh
participant ThemeFile as XDG theme file
User->>ThemeCommand: Request theme list or preview
ThemeCommand->>Renderer: List themes or render preview
Renderer-->>ThemeCommand: Theme names or rendered output
User->>ThemeCommand: Save selected theme
ThemeCommand->>ThemeFile: Atomically write selection
Merge Risk: ⚪ Minimal · up to No actionable issue remains from this review; the PR is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)Full details: Docstring CoverageExplanation Docstring coverage is 43.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 39 functions across 4 files. (9 skipped: 9 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Action performedReview finished.
|
|
@coderabbitai review |
|
Summary
Selectable themes, a packaged theme chooser, and a few line-1 refinements.
STATUSLINE_THEMEor the saved choice in$XDG_CONFIG_HOME/cc-statusline/theme:tokyo-auto(new default, follows OS light/dark with a 60s cache),tokyo-night,tokyo-day(official tokyonight.nvim Day palette),classic(the previous look, byte-identical),hue-dark,nord,phosphor,synthwave(post-layout neon gradient),gruvbox,dracula,catppuccin;defaultaliasestokyo-auto. Users with~/.claude/statusline-color-overrides.jsonand no explicit choice keepclassic.cc-statusline-themechooser, shipped with brew andinstall.sh: fzf picker with the list on top and a full-width 2-row live preview (numbered menu without fzf), current theme marked,list/current/set/reset/preview. Previews use isolated caches, no fetchers, no tab-title writes, fsmonitor off. Reports when a change applies and whethersettings.jsonoverrides it.@handle(dropped whole after k8s on overflow); only the update notice stays right-aligned. The auto session title is remembered across/rename, and a title equal to the visible handle is hidden.install.shcould fail intermittently (git archive SIGPIPE underpipefail); the archive is now staged to a private temp file.STATUSLINE_TAB_TITLE=0to skip the tab-title write.Invariants kept
WIDTH_SLOP=0; segment caps/joins are measured, and the Synthwave gradient pass only adds zero-width SGRs after all width decisions.classicmatches the v3.6.0 output byte for byte (108 renders across all fixtures, widths and phone layout; permanent ANSI goldens added).Validation
task cigreen locally in both locales: 1202 render, 75 fetch, 3 installer tests each.task test-themes-full(opt-in exhaustive: every theme x fixture x width plus a 20..60 column sweep) green in both locales.🤖 Generated with Claude Code
Summary by CodeRabbit